Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Update to React 18 #425

Open
wjamro opened this issue Aug 2, 2024 · 1 comment
Open

[Question] Update to React 18 #425

wjamro opened this issue Aug 2, 2024 · 1 comment

Comments

@wjamro
Copy link

wjamro commented Aug 2, 2024

First of all, thank you for the awesome work you do.
Jumping straight to the point: Do you plan to update the web-template to React 18 anytime soon?

@Gnito
Copy link
Contributor

Gnito commented Aug 8, 2024

@wjamro Yes, we are planning to update to React v18.

The challenge is that there has been at least 2 libraries that are prohibiting this: React Dates and Enzyme. We kicked Enzyme out earlier, but react-dates (a date-picking library) needs more work before it can be removed.

We have an ongoing project to create new date-picking component and start using it on different places where react-dates is in use. On top of that, there might be some other work needed before React 18 can be supported. At least, hydration logic has changed on v18, which might mean that there can be hydration issues that needs to be addressed. However, before we continue with this work, there are some permission-related projects that need to be completed first.

Background story:
Both libraries were originally created by AirBnB, but they transferred the ownership to some solo OS dev, when they changed their frontend stack few years back.

React Dates has its internal tests written with Enzyme testing library. The Enzyme testing library needs adaptors to work with any given version of React. IIRC, the reason, why Enzyme does not support newer React versions, was that React team hasn't released docs on how to hook on those version specific virtual-dom fragments that the Enzyme needs. I'm not sure if that's the whole story.

As a summary, Enzyme is not updated - and React Dates is not updated, because its internal enzyme-based tests are not updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants