Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] 공개상담 ios 키보드 이슈 #377

Merged
merged 9 commits into from
Aug 8, 2024

Conversation

kyuhho
Copy link
Contributor

@kyuhho kyuhho commented Aug 7, 2024

Checklist


  • 올바른 브랜치에 PR을 보내도록 설정하였나요?
  • PR의 라벨을 올바르게 달았나요?

Description


�공개상담 글과 댓글 작성을 동시에 하지못하는 ios 키보드 이슈 해결한 PR입니다.

keyboard event가 발생할때 마다 footer의 bottom 값을 수정하는 방향으로 구현하였습니다.


Related Issues


#373

@kyuhho kyuhho added Bug 기능 오류 발생 및 픽스 Stage-2/code-review-request work done and CI passed labels Aug 7, 2024
@kyuhho kyuhho self-assigned this Aug 7, 2024
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for candid-semolina-d0db42 ready!

Name Link
🔨 Latest commit 0b2c4be
🔍 Latest deploy log https://app.netlify.com/sites/candid-semolina-d0db42/deploys/66b33563269b7400082937b3
😎 Deploy Preview https://deploy-preview-377--candid-semolina-d0db42.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmdnps10
Copy link
Contributor

rmdnps10 commented Aug 8, 2024

LGTM :)

Safari 모바일 기기에서 테스트해보았는데 답장하고 Input 포커스되어 visualViewport가 줄어들 때, bottom값이 재조정되어 키보드 바로 위로 Input의 위치가 조정되는 거 확인했습니다. 조금 스크롤할 때 잘 안올라갈 때(?)가 있는 거 같기는한데 이게 최선인거같아요!
고생하셨습니다

@rmdnps10 rmdnps10 merged commit 8d1bca3 into dev Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 기능 오류 발생 및 픽스 Stage-2/code-review-request work done and CI passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants