Add application command localization support. #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on command create and edit methods.
…cation command object.
…thods for creating and editing of application commands.
…teractions::OptionBuilder methods.
Droid00000
suggested changes
Oct 14, 2024
There was a problem hiding this comment.
Oh, sorry, I forgot to mention, but could you please include the with_localizations field on #get_application_commands as well, if it's not too much trouble 😅
|
I’ll try to do that and rebase the branch soon. |
expeehaa
force-pushed
the
add_application_command_localization_support
branch
2 times, most recently
from
2840504 to
f90cb1f
Compare
expeehaa
force-pushed
the
add_application_command_localization_support
branch
3 times, most recently
from
21eef87 to
67cf6a9
Compare
expeehaa
force-pushed
the
add_application_command_localization_support
branch
from
67cf6a9 to
2c990aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for registering and editing name and description localizations of application commands and their options. I took a slightly different approach than in #190, because I don’t like the additional builder.
Added
name_localizationsanddescription_localizationsproperties of application commands and their optionswith_localizationswhen callingDiscordrb::Bot#get_application_commands.