Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::variant in Token class #11

Open
peldax opened this issue Oct 28, 2016 · 2 comments
Open

Use std::variant in Token class #11

peldax opened this issue Oct 28, 2016 · 2 comments
Assignees
@NTSFka
Labels
A - in development B - enhancement C - medium priority D - tokenizer
Milestone
Tokenizer 0.3

Comments

@peldax
Copy link
Member

peldax commented Oct 28, 2016

No description provided.

@peldax peldax added this to the Tokenizer 0.3 milestone Oct 28, 2016
@peldax peldax self-assigned this Oct 28, 2016
@peldax
Copy link
Member Author

peldax commented Nov 22, 2016

Waiting for std::variant from c++17

@NTSFka
Copy link
Contributor

NTSFka commented Nov 22, 2016

I think the custom implementation will be better than std::variant. The std::variant requires to be in a valid state where exactly value of one type must be stored, but Token can be in state where no value is stored.

@peldax peldax closed this as completed Nov 24, 2016
@peldax peldax reopened this Nov 25, 2016
@peldax peldax assigned NTSFka and unassigned peldax Nov 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NTSFka NTSFka

Labels
A - in development B - enhancement C - medium priority D - tokenizer
Projects
None yet
Milestone
Tokenizer 0.3
Development

No branches or pull requests
2 participants
@NTSFka @peldax