fix(shadcn): use system proxy settings (#3869) #5952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a small PR in order to use system wide proxy settings for fetching the remote repository.
I used
proxy-agent
package, which is a "super package" on top ofhttps-proxy-agent
(among others).The main benefit from this change is to use the correct proxy in all situations:
HTTPS_PROXY
(uppercase) instead ofhttps_proxy
(lowercase)http_proxy
setting (no HTTPS), in case you've usedREGISTRY_URL
with an HTTP URLno_proxy
setting whenever it's relevant1Note: I've seen the same kind of code in
packages/cli
source command, but I've not updated it because of its deprecation notice.Note: I'm not yet fluent with pnpm. There a quite a few changes inside its lock file, but the only 2 commands I ran was
pnpm install proxy-agent
andpnpm remove https-proxy-agent
.pnpm test
are running successfully (on gitpod.io).Notes:
https_proxy
is set on my env. for all outgoing requests, butno_proxy
is configured with an exception for shadcn URL, and this exception was not use within the shadcn cli