Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: GitHub link in site header is only clickable on icon #5887

Open
2 tasks done
olegpolin opened this issue Nov 20, 2024 · 0 comments · May be fixed by #5888
Open
2 tasks done

[bug]: GitHub link in site header is only clickable on icon #5887

olegpolin opened this issue Nov 20, 2024 · 0 comments · May be fixed by #5888
Labels
bug Something isn't working

Comments

@olegpolin
Copy link

Describe the bug

The GitHub link in the site header is only clickable on the icon, if the button is clicked outside of the icon, the link doesn't work.

This is solved by using asChild as documented in https://ui.shadcn.com/docs/components/button

Affected component/components

Button, Link

How to reproduce

  1. Go to https://ui.shadcn.com/
  2. Click on the GitHub link in the site header, clicking outside of the icon
  3. Doesn't work

Codesandbox/StackBlitz link

No response

Logs

No response

System Info

Any system

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues
@olegpolin olegpolin added the bug Something isn't working label Nov 20, 2024
olegpolin added a commit to olegpolin/ui that referenced this issue Nov 20, 2024
@olegpolin
fix(www): github link button in site header (shadcn-ui#5887)
b251577
@olegpolin olegpolin linked a pull request Nov 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(www): github link button in site header olegpolin/ui
1 participant
@olegpolin