Skip to content

Commit

Permalink
Merge fixes into main
Browse files Browse the repository at this point in the history
  • Loading branch information
sgwilym committed Jun 19, 2024
2 parents fca58e1 + 0eb21b6 commit 386fa9b
Show file tree
Hide file tree
Showing 8 changed files with 435 additions and 433 deletions.
19 changes: 7 additions & 12 deletions .nova/Configuration.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
{
"co.gwil.deno.config.trustedImportHosts" : [
"https:\/\/deno.land"
],
"deno.cacheOnSave" : true,
"deno.enablePaths" : [
"src",
"build.ts",
"deno.json"
],
"deno.lint" : true,
"workspace.art_style" : 0,
"workspace.name" : "nova-deno"
"co.gwil.deno.config.trustedImportHosts": [
"https:\/\/deno.land"
],
"deno.cacheOnSave": true,
"deno.lint": true,
"workspace.art_style": 0,
"workspace.name": "nova-deno"
}
17 changes: 9 additions & 8 deletions deno.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
{
"tasks": {
"build": "deno run --allow-all --unstable build.ts"
},
"imports": {
"lsp": "npm:vscode-languageserver-types",
"strip-json": "https://esm.sh/strip-json-comments",
"nova-utils": "../nova_utils/mod.ts"
}
"tasks": {
"build": "deno run --allow-all --unstable build.ts"
},
"imports": {
"lsp": "npm:vscode-languageserver-types",
"strip-json": "https://esm.sh/strip-json-comments",
"nova-utils": "../nova_utils/mod.ts"
},
"exclude": ["deno.novaextension"]
}
9 changes: 8 additions & 1 deletion deno.novaextension/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## NEXT

- Add a new "Reload Import Registries" command.
- Manually restart the server when the config file changes.
- The "Cache dependencies" command was broken by the underlying command having been removed from the LSP. It has now been updated to the new command.
- Removed the workspace "Enabled paths" and "Disabled paths" setting. If you were to add some enabled paths and remove all of them, Nova would leave an empty array, which would make the Deno LSP decide not to be enabled for anything. If you need to conditionally disable which files are analysed by the LSP, use the deno.json `exclude` option to do so.

## v1.4.3

- Changed fallback value for `deno.enablePaths`, as newer versions of Deno LSP
Expand All @@ -7,7 +14,7 @@

- The per-workspace setting for enabling unstable Deno APIs is now _really_
respected.
- Preferences for lining, cache on save, and complete function calls have all
- Preferences for linting, cache on save, and complete function calls have all
been moved to workspace settings. Changing these settings will no longer
restart the LSP client!
- Fixed an out of bounds issue for LSP <> Nova range conversions.
Expand Down
24 changes: 7 additions & 17 deletions deno.novaextension/extension.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,23 +82,6 @@
"type": "boolean",
"default": true
},
{
"key": "deno.enablePaths",
"title": "Enabled paths",
"description": "Restrict extension functionality to the specified paths.",
"type": "pathArray",
"allowFolders": true,
"relative": true
},
{
"key": "deno.disablePaths",
"title": "Disabled paths",
"description": "Exclude extension functionality from the specified paths.",
"type": "pathArray",
"allowFolders": true,
"relative": true,
"default": []
},
{
"key": "deno.importMap",
"title": "Import map",
Expand Down Expand Up @@ -203,6 +186,13 @@
"syntaxes": ["typescript", "tsx", "javascript", "jsx"]
}
},
{
"title": "Reload Import Registries",
"command": "co.gwil.deno.commands.reloadImportRegistries",
"filters": {
"syntaxes": ["typescript", "tsx", "javascript", "jsx"]
}
},
{
"title": "Restart Deno LSP server",
"command": "co.gwil.deno.commands.restartServer"
Expand Down
Loading

0 comments on commit 386fa9b

Please sign in to comment.