Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern book names in translation queries #37

Open
nivaca opened this issue Jul 5, 2020 · 2 comments
Open

Modern book names in translation queries #37

nivaca opened this issue Jul 5, 2020 · 2 comments

Comments

@nivaca
Copy link

nivaca commented Jul 5, 2020

Currently to use the API to query for a translation, one has to use the target language's book names, e.g.:

http://bible-api.com/Joannes+3:16?translation=clementine

Whereas using the English names of those books does not work:

http://bible-api.com/John+3:16?translation=clementine

Could the API be fixed so it does work? (I usually don't recall the Latin names of all the books from the Vulgata).

Thanks.

@seven1m
Copy link
Owner

seven1m commented Jul 6, 2020

Thanks for the issue. It's been awhile since I worked on this, but I think the solution is to update this file: https://github.com/seven1m/bible_ref/blob/master/lib/bible_ref/languages/latin.rb

It should look something more like this one: https://github.com/seven1m/bible_ref/blob/master/lib/bible_ref/languages/portuguese.rb

If you are able to help, I would accept a PR over on the bible_ref repository! If not, I will get around to it someday...

@nivaca
Copy link
Author

nivaca commented Jul 6, 2020

Sure, I'll give it a try.
Best.

johndoesniper added a commit to johndoesniper/bible_ref that referenced this issue Jul 26, 2021
Added match patterns to respective books. Also included roman numerals with corresponding modern numbering system. @seven1m What other changes are necessary to get this version going? I'm rather new to this platform so let me know if I need to go about this some other way as I was hoping to contribute to seven1m/bible_api#37.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants