refactor: ignore handlers with image.name
property
#1885
+68
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #1884
Ignoring the handlers with the the
image.name
property the same way the ones withimage.uri
are ignored as they are lambda containers.How did you implement it:
How can we verify it:
Create a serverless template with both a lambda handler and a lambda container. The lambda container should have the
image.name
property poiting to anecr
image defined in the same template. The following example can be used:Run serverless package
The packager should not throw any error. It should package
functionHandler
and build the imagetest-image
for the functionfunctionContainer
(you would need to make sure you have a validDockerfile
in the root folder for the image to build).output in master
output in this branch
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO