Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocklist validation broken #16

Open
ignoramous opened this issue Aug 25, 2021 · 0 comments
Open

Blocklist validation broken #16

ignoramous opened this issue Aug 25, 2021 · 0 comments
Assignees

Comments

@ignoramous
Copy link
Contributor

hosts files were marked domains while one another file was neither hosts nor domains. The validation run succeeded anyway when it shouldn't have.

Exhibit A: Every blocklist file in the serverless-dns/blocklists/runs/3372744250 should have been a validation failure, but isn't:

177 : Downloading From : https://ngosang.github.io/trackerslist/trackers_all.txt
Download Location : ./blocklistfiles/privacy/176.txt
178 : Downloading From : https://blocklistproject.github.io/Lists/torrent.txt
Download Location : ./blocklistfiles/parentalcontrol/177.txt
179 : Downloading From : https://blocklistproject.github.io/Lists/drugs.txt
Download Location : ./blocklistfiles/parentalcontrol/178.txt
180 : Downloading From : https://blocklistproject.github.io/Lists/ransomware.txt
Download Location : ./blocklistfiles/security/179.txt
181 : Downloading From : https://blocklistproject.github.io/Lists/tiktok.txt
Download Location : ./blocklistfiles/parentalcontrol/social-networks/180.txt
182 : Downloading From : https://blocklistproject.github.io/Lists/malware.txt
Download Location : ./blocklistfiles/security/181.txt
183 : Downloading From : https://blocklistproject.github.io/Lists/phishing.txt
Download Location : ./blocklistfiles/security/182.txt
184 : Downloading From : https://blocklistproject.github.io/Lists/ads.txt
Download Location : ./blocklistfiles/privacy/183.txt
185 : Downloading From : https://blocklistproject.github.io/Lists/crypto.txt
Download Location : ./blocklistfiles/security/cryptojacking/184.txt
186 : Downloading From : https://blocklistproject.github.io/Lists/porn.txt
Download Location : ./blocklistfiles/parentalcontrol/porn/185.txt
187 : Downloading From : https://blocklistproject.github.io/Lists/whatsapp.txt
Download Location : ./blocklistfiles/parentalcontrol/social-networks/186.txt
188 : Downloading From : https://blocklistproject.github.io/Lists/vaping.txt
Download Location : ./blocklistfiles/parentalcontrol/187.txt
189 : Downloading From : https://blocklistproject.github.io/Lists/piracy.txt
Download Location : ./blocklistfiles/parentalcontrol/piracy/188.txt
190 : Downloading From : https://blocklistproject.github.io/Lists/facebook.txt
Download Location : ./blocklistfiles/parentalcontrol/social-networks/189.txt
191 : Downloading From : https://blocklistproject.github.io/Lists/gambling.txt
Download Location : ./blocklistfiles/parentalcontrol/gambling/190.txt
192 : Downloading From : https://blocklistproject.github.io/Lists/basic.txt
Download Location : ./blocklistfiles/privacy/191.txt
193 : Downloading From : https://blocklistproject.github.io/Lists/everything.txt
Download Location : ./blocklistfiles/privacy/192.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants