Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap SOL when payer == owner for place_order on SOL market #95

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

DaveWK
Copy link
Contributor

@DaveWK DaveWK commented Nov 5, 2021

I propose the logic for place_order on SOL markets should transparently do the Create/Close wrapped SOL token mint transactions when owner==payer on a SOL market. At the moment the logic doesn't have a clear path for what to specify for "payer" when paying for an order with SOL. The SOL wrapping is transparent to the end user since the transaction closes the wrapped sol account.

If this is acceptable, please let me know how you'd like to orchestrate a test market that has the WRAPPED_SOL_MINT as either base/quote for the tests, and I'll add it.

@adrida
Copy link

adrida commented Jun 25, 2022

Hi, what is the current solution to placing an order on SOL markets? Doesn't seem to work with the owner public key as a token address for SOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants