Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with Moshi codegen #73

Open
micHar opened this issue Mar 8, 2019 · 2 comments
Open

Not working with Moshi codegen #73

micHar opened this issue Mar 8, 2019 · 2 comments

Comments

@micHar
Copy link

micHar commented Mar 8, 2019

Hi, the idea for this lib is really awesome. The only problem now is that it doesn't seem to work with newer codegen moshi, the generated adapter for @wrapped member still complains about the original name not being found in the json. Do you plan to work on this issue?

@serj-lotutovici
Copy link
Owner

Thanks for the report.
I would expect it to work out of the box, can you provide a failing test in PR? I may have some time to work on it this Sunday.

@micHar
Copy link
Author

micHar commented Mar 10, 2019

Sorry, I removed the code and moved on with regular wrappers. But I can try to prepare some test case in a few days and will let you know.
The thing I remember, though, is that when I looked at the generated adapters, there was some mention on the @wrapped there, but still it contained the checks for regular member names, so it just could not work. But I need to build this piece of code it again to elaborate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants