diff --git a/Readme.md b/Readme.md index faa3db2..17f37fe 100644 --- a/Readme.md +++ b/Readme.md @@ -12,6 +12,8 @@ ## Recent Updates +* **version 6.12.4 12sep2023**: + - Fix `ivreghdfe` bug when clustering with string variables (#276) * **version 6.12.3 20aug2023**: - Bugfix for parallel option (macOS) - Fix typos in help file diff --git a/current-code/reghdfe.ado b/current-code/reghdfe.ado index 7cc50c2..d25d23f 100644 --- a/current-code/reghdfe.ado +++ b/current-code/reghdfe.ado @@ -1,4 +1,4 @@ -*! version 6.12.3 08aug2023 +*! version 6.12.4 12sep2023 program define reghdfe * Intercept storing alphas @@ -260,7 +260,7 @@ program Estimate, eclass * We will just create and fill the HDFE object loc touse `varlist' loc varlist - markout `touse' `base_clustervars' `group_id' `individual_id' + markout `touse' `base_clustervars' `group_id' `individual_id', strok } else { * Set sample based on if + in + weight + group + individual + cluster variables + regression varlist (i.e. excluding absvars) diff --git a/current-code/reghdfe.pkg b/current-code/reghdfe.pkg index c012f3f..f63bcb2 100644 --- a/current-code/reghdfe.pkg +++ b/current-code/reghdfe.pkg @@ -31,7 +31,7 @@ d d Required packages: d ftools d -d Distribution-Date: 20230820 +d Distribution-Date: 20230912 d f reghdfe.ado diff --git a/current-code/reghdfe.sthlp b/current-code/reghdfe.sthlp index b33fb9c..01d9def 100644 --- a/current-code/reghdfe.sthlp +++ b/current-code/reghdfe.sthlp @@ -1,5 +1,5 @@ {smcl} -{* *! version 6.12.3 08aug2023}{...} +{* *! version 6.12.4 12sep2023}{...} {vieweralsosee "[R] areg" "help areg"}{...} {vieweralsosee "[R] xtreg" "help xtreg"}{...} {vieweralsosee "" "--"}{...} diff --git a/src/reghdfe.ado b/src/reghdfe.ado index 7cc50c2..d25d23f 100644 --- a/src/reghdfe.ado +++ b/src/reghdfe.ado @@ -1,4 +1,4 @@ -*! version 6.12.3 08aug2023 +*! version 6.12.4 12sep2023 program define reghdfe * Intercept storing alphas @@ -260,7 +260,7 @@ program Estimate, eclass * We will just create and fill the HDFE object loc touse `varlist' loc varlist - markout `touse' `base_clustervars' `group_id' `individual_id' + markout `touse' `base_clustervars' `group_id' `individual_id', strok } else { * Set sample based on if + in + weight + group + individual + cluster variables + regression varlist (i.e. excluding absvars) diff --git a/src/reghdfe.pkg b/src/reghdfe.pkg index 925fe51..d657dc5 100644 --- a/src/reghdfe.pkg +++ b/src/reghdfe.pkg @@ -31,7 +31,7 @@ d d Required packages: d ftools d -d Distribution-Date: 20230820 +d Distribution-Date: 20230912 d f reghdfe.ado diff --git a/src/reghdfe.sthlp b/src/reghdfe.sthlp index b33fb9c..01d9def 100644 --- a/src/reghdfe.sthlp +++ b/src/reghdfe.sthlp @@ -1,5 +1,5 @@ {smcl} -{* *! version 6.12.3 08aug2023}{...} +{* *! version 6.12.4 12sep2023}{...} {vieweralsosee "[R] areg" "help areg"}{...} {vieweralsosee "[R] xtreg" "help xtreg"}{...} {vieweralsosee "" "--"}{...} diff --git a/test/test-dependencies.do b/test/test-dependencies.do new file mode 100644 index 0000000..28f1aed --- /dev/null +++ b/test/test-dependencies.do @@ -0,0 +1,39 @@ +* =========================================================================== +* Test that all upstream/downstream reghdfe dependencies work +* =========================================================================== +* Note: this changes PLUS so best to restart Stata afterwards + + clear all + + +// -------------------------------------------------------------------------- +// Test SSC +// -------------------------------------------------------------------------- + + tempfile adopath + loc adopath "C:\Git\asd\fakeado" + di as text `"tempfile=`adopath'"' + *mkdir "`adopath'", public + + sysdir set PLUS "`adopath'" + + net install require, from("C:\Git\stata-require\src") // SSC version is still 1.1.1 + require moremata , install + require require >= 1.3 , install + require ftools >= 2.49.1 , install + require reghdfe >= 6.12.3 , install + require ppmlhdfe >= 2.3.0 , install + *require ivreghdfe >= 1.1.3 , install // problem: SSC still has ivreghdfe 1.0.0 + + sysuse auto + fcollapse (sum) price, by(turn) + + sysuse auto, clear + reghdfe price weight length, a(turn) + *ivreghdfe price (weight=length), a(turn) + + set trace on + set tracedepth 1 + ppmlhdfe turn weight length, a(trunk) + +exit