Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Replace use of joda-time with plain java time handling? #61

Open
madsop-nav opened this issue Apr 12, 2024 · 3 comments
Open
Labels
dependencies Pull requests that update a dependency file

Comments

@madsop-nav
Copy link

It would be nice if this library could come without external dependencies, or at least as close as possible.

I believe that the use of Joda-time here could be replaced with plain Java time handling (using the Date and Time API introduced in Java 8).

@seratch seratch added the dependencies Pull requests that update a dependency file label Apr 12, 2024
@seratch
Copy link
Owner

seratch commented Apr 12, 2024

Hi, thanks for the suggestion! Indeed, newly created apps may want to get rid of the 3rd party dependency but I still want to keep backward-compatibility for a while. With that being said, this project will remove (or move the joda-time support to an optional module) when I get the confidence that most developers are happy with it in the future.

@seratch
Copy link
Owner

seratch commented Apr 12, 2024

I forgot to mention this. This library already supports java.time.* classes by default. You still need to accept the unnecessary joda-time resolution but there is no blocker if you want to use java.time.* APIs instead.

@madsop-nav
Copy link
Author

Thanks for a conscious and nice reply! Our code scan analysis gives a warning on the current version having a CVE, which lead me into suggesting replacing it: https://nvd.nist.gov/vuln/detail/CVE-2024-23080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants