Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seqerakit docs port #296

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Seqerakit docs port #296

wants to merge 25 commits into from

Conversation

llewellyn-sl
Copy link
Contributor

@llewellyn-sl llewellyn-sl commented Nov 11, 2024

@netlify /platform/24.1/seqerakit/installation

Ports and simplifies the Seqerakit docs into Platform Developer Tools.

TODO:

  • Port final pages to 24.2, 23.4, and 23.3
  • Clean up seqerakit repo

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit e3c3b73
🔍 Latest deploy log https://app.netlify.com/sites/seqera-docs/deploys/6748497e87c64200087e26a3
😎 Deploy Preview https://deploy-preview-296--seqera-docs.netlify.app/platform/24.1/seqerakit/installation
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback about formatting which we'll apply across other developer docs if we're all in agreement.

Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you so much!

@justinegeffen justinegeffen added 1. Editor review Needs a language review 2. Dev/PM review Needs a review by a Dev or PM and removed 1. Editor review Needs a language review labels Nov 21, 2024
@christopher-hakkaart
Copy link
Member

christopher-hakkaart commented Nov 22, 2024

I've added two small comments. I wouldn't consider either of these blocking.

@jason-seqera
Copy link
Contributor

@llewellyn-sl, the recognized terminal highlight styles are in docusaurus.config.js. We don't have a console, but shell-session ought to be similar. Anything not listed is just ignored. (Using any random value is actually required to get title= to work though which is weird.)

          "bash",
          "docker",
          "groovy",
          "ini",
          "java",
          "json",
          "nginx",
          "python",
          "r",
          "shell-session",
          "sql",
          "typescript",
          "yaml"

Copy link
Member

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

Minor suggestions:

  • I think Seqerakit in the descriptions qualifies as the product name and should be capitalized
  • --help is an option not a parameter
  • Flags are boolean options (please correct me if I'm wrong)

@@ -0,0 +1,126 @@
---
title: "Commands"
description: "seqerakit command options"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "seqerakit command options"
description: "Seqerakit command options"

Thoughts?

tags: [seqerakit, cli, automation, commands]
---

Use the `--help` or `-h` parameter to list available commands and options:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the `--help` or `-h` parameter to list available commands and options:
Use the `--help` or `-h` option to list available commands and options:

Seqerakit: Python wrapper for the Seqera Platform CLI
options:
-h, --help show this help message and exit


### Specify targets

When using a YAML file as input that defines multiple resources, use the `--targets` flag to specify which resources to create. This flag accepts a comma-separated list of resource names.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When using a YAML file as input that defines multiple resources, use the `--targets` flag to specify which resources to create. This flag accepts a comma-separated list of resource names.
When using a YAML file as an input that defines multiple resources, use the `--targets` flag to specify which resources to create. This flag accepts a comma-separated list of resource names.

Comment on lines +72 to +77
pipelines:
- name: "hello-world"
url: "https://github.com/nextflow-io/hello"
workspace: 'seqerakit/workspace-1'
compute-env: "compute-env"
...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single vs double quotes. I'm not sure if this is important.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we should go with single to match all the values in the templates.


The Platform CLI expects to connect to a Seqera instance that is secured by a TLS certificate. If your Seqera Enterprise instance does not present a certificate, you must run your `tw` commands with the `--insecure` flag.

To use `tw`-specific CLI options such as `--insecure`, use the `--cli=` flag, followed by the options to use enclosed in double quotes:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To use `tw`-specific CLI options such as `--insecure`, use the `--cli=` flag, followed by the options to use enclosed in double quotes:
To use `tw`-specific CLI options such as `--insecure`, use the `--cli=` option, followed by the options to use enclosed in double quotes:

For me, flag is a type of option that is reserved for booleans.

seqerakit --version
```

Use the `--help` or `-h` parameter to list the available commands and their associated options:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the `--help` or `-h` parameter to list the available commands and their associated options:
Use the `--help` or `-h` option to list the available commands and their associated options:

@@ -0,0 +1,117 @@
---
title: "Installation"
description: "seqerakit installation options"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "seqerakit installation options"
description: "Seqerakit installation options"

@@ -0,0 +1,200 @@
---
title: "Templates"
description: "seqerakit YAML configuration file templates and instructions"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "seqerakit YAML configuration file templates and instructions"
description: "Seqerakit YAML configuration file templates and instructions"

Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Minor feedback.


To use the templates on this page:
1. Copy the template text or download the YAML files you need.
1. Edit the values to specify your resource details, and save as a YML file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Edit the values to specify your resource details, and save as a YML file.
1. Edit the values to specify your resource details, and save as a `.yaml` file.

To use the templates on this page:
1. Copy the template text or download the YAML files you need.
1. Edit the values to specify your resource details, and save as a YML file.
1. Specify the YML template file in your `seqerakit` commands:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Specify the YML template file in your `seqerakit` commands:
1. Specify the YAML template file in your `seqerakit` commands:

Comment on lines +72 to +77
pipelines:
- name: "hello-world"
url: "https://github.com/nextflow-io/hello"
workspace: 'seqerakit/workspace-1'
compute-env: "compute-env"
...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we should go with single to match all the values in the templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. Dev/PM review Needs a review by a Dev or PM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants