Fixed ECDH for curve25519 so it uses X25519 #1386
Open
+181
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-r-p
approved these changes
Dec 9, 2024
stggn
reviewed
Dec 9, 2024
There was a problem hiding this comment.
With ECDH and 'curve25519' the secrets are now different, while with other curves they are identical:
//'c2pnb208w1' 'curve' STORE
'curve25519' 'curve' STORE
$curve ECGEN
ECPUBLIC 'pub1' STORE
ECPRIVATE 'priv1' STORE
$curve ECGEN
ECPUBLIC 'pub2' STORE
ECPRIVATE 'priv2' STORE
$priv1 $pub2 ECDH
$priv2 $pub1 ECDH
This is the reason for this PR, the DH done using curve25519 was incorrect until this PR. |
|
PTAL had to fix public key computation from private key when using curve25519 as it was not using the correct approach. |
… thus ensuring that the pubkey is correctly computed for curve25519
|
The latest ECGEN fix leads to the correct shared secret in your ECDH test. Could you add that test to the ECDH doc please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.