Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo installation is handled by uchiwa and sensu itself #46

Open
runningman84 opened this issue Nov 21, 2015 · 4 comments
Open

Repo installation is handled by uchiwa and sensu itself #46

runningman84 opened this issue Nov 21, 2015 · 4 comments

Comments

@runningman84
Copy link

Right now, the sensu repo is added by the sensu-chef and the uchiwa-chef cookbook. This creates chef warnings and leads to other funny problems.

I would recommend these steps:

  • move the repo.rb to the sensu-chef cookbook
  • add a package.rb recipe to uchiwa-chef cookbook which installs only the uchiwa package itself
  • remove the repo handling from _linux.rb in sensu-chef cookbook
@majormoses
Copy link
Contributor

Hmm the issue is that sensu and uchiwa cookbooks are meant to be decoupled and be able to run independently. I think that you probably should remove the repo.rb from your runlist if you are running both of them on the same instance. We might be able to inspect the collection of resources to conditionally assign it.

@majormoses
Copy link
Contributor

I see that here we include the recipe so ya I see where you are coming from. I think what makes the most sense is to create custom resources that give you all of that functionality so you can decide how to implement it in your wrapper.

@sspans
Copy link

sspans commented May 6, 2019

or use 'includepkgs' to only pull in sensu/uchiwa from a particular repo

@majormoses
Copy link
Contributor

@sspans if you want to submit a PR I am open to it, I am going to be working on moving to sensu-go in a few months and I have not had issues with my existing setup. If someone wants to submit a PR I am all ears but I am not likely gonna spend any time looking into improving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants