-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Etcd cleanup #5064
Closed
Closed
Etcd cleanup #5064
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5b52880
etcd user session cleanup every 11 minutes
ManishaKumari295 edf94b0
added change log
ManishaKumari295 7ace887
6 mins ttl for user sessions
ManishaKumari295 6c08054
6 mins ttl for user sessions
ManishaKumari295 da0b51a
added 6 mins ttl for user sessions
ManishaKumari295 2d32a3d
added 6 mins ttl for each user sessions
ManishaKumari295 d1eb3fb
added 6 mins ttl for each user_sessions
ManishaKumari295 596c906
ttl hardcoding removed
ManishaKumari295 32e117f
ttl hardcoding removed
ManishaKumari295 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,12 +30,15 @@ func (s *Store) GetSession(ctx context.Context, username, sessionID string) (str | |
} | ||
|
||
// UpdateSession applies the supplied state to the session uniquely identified | ||
// by the given username and session ID. | ||
// by the given username and session ID and TTL of 6 minutes added considering access token expires in 5 minutes | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of hard-coding the value to 6 minutes I would calculate it based on the token expiration. I think something like (token expiration * 1.5) would be ok. |
||
func (s *Store) UpdateSession(ctx context.Context, username, sessionID, state string) error { | ||
if _, err := s.client.Put(ctx, userSessionPath(username, sessionID), state); err != nil { | ||
leaseResp, err := s.client.Grant(ctx, 60*6) | ||
if err != nil { | ||
return fmt.Errorf("%s", err) | ||
} | ||
if _, err := s.client.Put(ctx, userSessionPath(username, sessionID), state, clientv3.WithLease(leaseResp.ID)); err != nil { | ||
return err | ||
} | ||
|
||
return nil | ||
} | ||
|
||
|
@@ -45,6 +48,5 @@ func (s *Store) DeleteSession(ctx context.Context, username, sessionID string) e | |
if _, err := s.client.Delete(ctx, userSessionPath(username, sessionID)); err != nil { | ||
return err | ||
} | ||
|
||
return nil | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rephrase this to something like this and have just one entry: