Update check-redshift-events.rb to AWS SDK v2 #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
approved these changes
Oct 27, 2018
CHANGELOG.md
Outdated
| @@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| This CHANGELOG follows the format listed [here](https://github.com/sensu-plugins/community/blob/master/HOW_WE_CHANGELOG.md) | |||
|
|
|||
| ## [Unreleased] | |||
| ### Breaking Changes | |||
| - `check-redshift-events.rb` was updated to aws-sdk v2 and no longer take `aws_access_key` and `aws_secret_access_key` options. (@boutetnico) | |||
There was a problem hiding this comment.
same comment as #297 (comment)
CHANGELOG.md
Outdated
| @@ -19,7 +21,7 @@ This CHANGELOG follows the format listed [here](https://github.com/sensu-plugins | |||
|
|
|||
| ## [12.1.0] - 2018-08-28 | |||
| ### Added | |||
| - new `check-efs.rb: checks cloudwatch metrics with the efs namespace for an arbitrary metric (@ivanfetch) | |||
| - new `check-efs.rb`: checks cloudwatch metrics with the efs namespace for an arbitrary metric (@ivanfetch) | |||
There was a problem hiding this comment.
you already made this change in another PR, please make this change in only one PR or it makes merging them more difficult.
5 tasks
|
I have asked for someone to test it that uses redshift: https://sensucommunity.slack.com/archives/C68LV5M9U/p1540867621031400 will give it ~48 hours before merging if we dont get anyone. |
|
released: https://rubygems.org/gems/sensu-plugins-aws/versions/13.0.0 I had to manually release because we have clogged up travis by enabling https://dependabot.com to help us with a lot of the maintenance work involved in keeping this project working so I can spend more time adding features and fixing bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclosure: I'm not a Ruby programmer, I cannot run the test suite, please review my changes. Also I don't have a Redshift cluster so I cannot test my changes, I'm just trying to make things move, can anyone using Redshift test this? Thanks
Pull Request Checklist
Issue related: #240
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Update to AWS SDK v2.
Known Compatibility Issues
This is a breaking change because it removes
aws_access_keyandaws_secret_access_keyoptions per #2.