Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create major (breaking) release without aws sdk v1 #240

Closed
runningman84 opened this issue Oct 4, 2017 · 14 comments · Fixed by #308
Closed

Create major (breaking) release without aws sdk v1 #240

runningman84 opened this issue Oct 4, 2017 · 14 comments · Fixed by #308
Labels
Help Wanted Impact: Breaking Change Priority: High Status: In Progress

Comments

@runningman84
Copy link
Contributor

It is not possible to install the aws plugins with the latest sensu releases:

`Unable to activate aws-sdk-v1-1.66.0, because json-2.1.0 conflicts with json (~> 1.4)` `json (2.1.0, default: 2.0.2, 1.8.6)`

In order to fix this I would propose the release of a new major release without any v1 checks.
@majormoses
Copy link
Member

@runningman84 thanks for raising the issue, I think we need to first take a look at the impact on the number of checks and either need to make a decision to remove or update them. ping @eheydrick

@eheydrick
Copy link
Collaborator

eheydrick commented Oct 10, 2017 •
edited by majormoses
Loading

Of the 76 checks, 11 are still using aws-sdk v1. I think we should put in the effort to update them to v2.

  • check-elb-certs.rb
  • check-elb-health-sdk.rb
  • check-elb-latency.rb
  • check-elb-nodes.rb
  • check-elb-sum-requests.rb
  • check-redshift-events.rb
  • handler-ses.rb
  • handler-sns.rb
  • metrics-ec2-count.rb
  • metrics-elb-full.rb
  • metrics-sqs.rb

EDIT: made it a checklist by @majormoses

This was referenced Oct 10, 2017
Merged
Merged
@eheydrick eheydrick mentioned this issue Oct 12, 2017
Merged
5 tasks
@majormoses majormoses mentioned this issue Oct 13, 2017
Closed
8 tasks
This was referenced Oct 13, 2017
Merged
Merged
Merged
@eheydrick
Copy link
Collaborator

5 checks have been updated to AWS-SDK v2 and released in 9.0.0. 6 left to update.
https://rubygems.org/gems/sensu-plugins-aws/versions/9.0.0.

@majormoses
Copy link
Member

I will try to take these ones this weekend:

  • check-elb-latency.rb
  • check-elb-sum-requests.rb

@majormoses
Copy link
Member

I added the handlers as they also required v1

@eheydrick
Copy link
Collaborator

I have handler-ses almost ready to PR. Going to do handler-sns after that.

@majormoses majormoses mentioned this issue Oct 20, 2017
Closed
This was referenced Oct 20, 2017
Merged
Merged
@eheydrick
Copy link
Collaborator

Handlers have been updated for AWS-SDK v2 and released in 10.0.0. Going to update the remaining 4 checks next. https://rubygems.org/gems/sensu-plugins-aws/versions/10.0.0

@majormoses
Copy link
Member

Sorry I have been super busy if I have some time I will get to it but if someone has the time feel free to jump in.

@eheydrick
Copy link
Collaborator

I have check-elb-latency just about ready to PR.

@multani
Copy link
Contributor

multani commented Dec 3, 2017

As a side note, check-elb-health-fog.rb and check-elb-health.rb are the only plugins not using the AWS SDK (nor v1 nor v2), but as explained in #254 (comment) I think they could be removed in favor of check-elb-health-sdk.rb which should do the same job as the two others.

@multani multani mentioned this issue Dec 3, 2017
Open
multani added a commit to multani/sensu-plugins-aws that referenced this issue Dec 11, 2017
@multani
Remove metrics-elb-full in favor of metrics-elb + fix --scheme and --…
1dfc11d 
…fetch_age

Both were doing mostly the same, in slightly different ways.

Once fixed, metrics-elb.rb has more features than metrics-elb-full.rb
(such as --period and --statistics, which are not available in the `-full`
variant) and supports the AWS-SDK v2, which helps for sensu-plugins#240
@multani multani mentioned this issue Dec 11, 2017
Merged
5 tasks
multani added a commit to multani/sensu-plugins-aws that referenced this issue Feb 7, 2018
@multani
Remove metrics-elb-full in favor of metrics-elb + fix --scheme and --…
1249047 
…fetch_age

Both were doing mostly the same, in slightly different ways.

Once fixed, metrics-elb.rb has more features than metrics-elb-full.rb
(such as --period and --statistics, which are not available in the `-full`
variant) and supports the AWS-SDK v2, which helps for sensu-plugins#240
majormoses pushed a commit that referenced this issue Feb 9, 2018
@multani @majormoses
Remove metrics-elb-full in favor of metrics-elb + fix --scheme and --…
e7fa6c9 
…fetch_age

Both were doing mostly the same, in slightly different ways.

Once fixed, metrics-elb.rb has more features than metrics-elb-full.rb
(such as --period and --statistics, which are not available in the `-full`
variant) and supports the AWS-SDK v2, which helps for #240
@majormoses
Copy link
Member

@multani thanks for helping out with this!

This was referenced Oct 24, 2018
Merged
Merged
Merged
@majormoses
Copy link
Member

All the assets have been updated, Great work and Thanks to everyone who pitched in.

@majormoses majormoses mentioned this issue Nov 2, 2018
Merged
5 tasks
@eheydrick
Copy link
Collaborator

Glad to see this come together. Thanks everyone!

@majormoses
Copy link
Member

released: https://rubygems.org/gems/sensu-plugins-aws/versions/16.0.0

@majormoses majormoses mentioned this issue Oct 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Impact: Breaking Change Priority: High Status: In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removing aws-sdk-v1 from the gemspec sensu-plugins/sensu-plugins-aws
4 participants
@multani @eheydrick @runningman84 @majormoses