Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover command from hdhomerun.com can return hdhomerun units on inaccessable IP addresses #52

Open
sengsational opened this issue Dec 29, 2024 · 1 comment

Comments

@sengsational
Copy link
Owner

If the local hdhomerun_config.exe discover command is not available, the program goes out to http://ipv4-api.hdhomerun.com/discover which returns the local IP addresses and devices. If the household has multiple subnets, not all tuners will necessarily be accessible.

One solution would be to include only devices on the subnet of the machine running CwHelper.

@sengsational
Copy link
Owner Author

sengsational commented Dec 30, 2024

Added functionality for just after the external http discover command to filter to include only IP addresses on the same subnet (using 255.255.255.0).

I moved the discover of the machine's IP out in a separate class, "NetworkDetails", out of TunerHdhr, where it was before. Then I was able to call it from TunerManager (which is the thing that creates the tuners).

d93c140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant