Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support full markdown syntax #397

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented Nov 29, 2024

How to test?

  • yarn dev. try copy and paste here then send a message.
  • or send message like below:
    • can you give me some random message with some markdown syntax applied?
    • can you give me another one with h1, h2, h3, ol and ul?
    • include any other markdown syntax I missed out. give me random authentic message.

You can also test workflow by sending below message:

  • give me a markdown message

Changes

  • Added support for wider range of markdown syntaxes

ticket: AC-4384

Additional Notes

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

@liamcho liamcho self-assigned this Nov 29, 2024
Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit b10856a
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/67594ee8c9a7690008297021
😎 Deploy Preview https://deploy-preview-397--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 29, 2024

Size Change: +15.1 kB (+2.5%)

Total Size: 619 kB

Filename Size Change
./dist/__bundle-b5ef7de4-********.js 891 B +1 B (+0.11%)
./dist/index-********.js 304 kB -1.66 kB (-0.54%)
./dist/index.es.js 172 B -1 B (-0.58%)
./dist/index.umd.js 289 kB +6.69 kB (+2.37%)
./dist/Placeholder.error-********.js 345 B -1 B (-0.29%)
./dist/Placeholder.loading-********.js 184 B -2 B (-1.08%)
./dist/PlaceholderCommon-********.js 245 B -2 B (-0.81%)
./dist/style.css 9.6 kB +923 B (+10.64%) ⚠️
./dist/TokensBody-********.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./dist/__bundle-46d64517-********.js 4.01 kB
./dist/__bundle-7c3d40f4-********.js 21 B
./dist/Placeholder.noChannels-********.js 183 B
./dist/Placeholder.noMessages-********.js 183 B

compressed-size-action

@liamcho liamcho marked this pull request as draft November 29, 2024 07:46
@liamcho liamcho requested a review from bang9 December 4, 2024 07:43
@liamcho liamcho force-pushed the feat/AC-44290-compare-markdown-libraries-2 branch 2 times, most recently from 1d3f996 to 96cefa1 Compare December 6, 2024 06:52
@liamcho liamcho changed the title feat: Markdown library comparison: markdown-to-jsx feat: Support full markdown syntax Dec 6, 2024
@liamcho liamcho marked this pull request as ready for review December 6, 2024 08:13
@liamcho liamcho requested a review from bang9 December 10, 2024 07:28
@liamcho liamcho added the 1.9.1 label Dec 10, 2024
@@ -29,6 +29,7 @@ test.afterEach(async ({ page }) => {
* 4. Submit form with valid values.
*/
test('100', async ({ page, browserName }) => {
await beforeEach(page);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모든 스텝에 들어가는거면, 이건 loadWidget 에 들어가도 되지 않나여?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵넵 loadWidget 함수로 빼겠씁니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

package.json Outdated Show resolved Hide resolved
@liamcho liamcho force-pushed the feat/AC-44290-compare-markdown-libraries-2 branch from 0ab9f14 to cd901b2 Compare December 11, 2024 04:02
@liamcho liamcho requested a review from bang9 December 11, 2024 04:04
@liamcho liamcho force-pushed the feat/AC-44290-compare-markdown-libraries-2 branch from 1c4989e to ad9576f Compare December 11, 2024 08:20
@liamcho liamcho force-pushed the feat/AC-44290-compare-markdown-libraries-2 branch from f8dda4f to b10856a Compare December 11, 2024 08:35
@liamcho liamcho merged commit 20dafbc into develop Dec 11, 2024
12 checks passed
@liamcho liamcho deleted the feat/AC-44290-compare-markdown-libraries-2 branch December 11, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants