Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-4189] feat: RTL #388

Merged
merged 9 commits into from
Nov 26, 2024
Merged

[AC-4189] feat: RTL #388

merged 9 commits into from
Nov 26, 2024

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented Nov 13, 2024

Changes

  • Added dir prop
  • Support RTL

ticket: AC-4189

Additional Notes

  • How to test? open the browser console and run document.body.setAttribute("dir", "rtl")

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit addeb4d
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/674456e04dae800008a49ce2
😎 Deploy Preview https://deploy-preview-388--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 13, 2024

Size Change: +367 B (+0.06%)

Total Size: 603 kB

Filename Size Change
./dist/__bundle-46d64517-********.js 4.01 kB +1 B (+0.02%)
./dist/__bundle-b5ef7de4-********.js 890 B +3 B (+0.34%)
./dist/index-********.js 306 kB +162 B (+0.05%)
./dist/index.es.js 173 B +3 B (+1.76%)
./dist/index.umd.js 283 kB +130 B (+0.05%)
./dist/Placeholder.error-********.js 346 B +1 B (+0.29%)
./dist/Placeholder.loading-********.js 186 B +5 B (+2.76%)
./dist/Placeholder.noChannels-********.js 183 B +3 B (+1.67%)
./dist/Placeholder.noMessages-********.js 183 B +3 B (+1.67%)
./dist/PlaceholderCommon-********.js 247 B +4 B (+1.65%)
./dist/style.css 8.68 kB +52 B (+0.6%)
ℹ️ View Unchanged
Filename Size
./dist/__bundle-7c3d40f4-********.js 21 B

compressed-size-action

@bang9 bang9 changed the base branch from develop to chore/remove-unused November 13, 2024 08:05
@bang9 bang9 changed the title chore: remove unused and update icon names feat: rtl Nov 13, 2024
@bang9 bang9 self-assigned this Nov 13, 2024
@bang9 bang9 marked this pull request as draft November 13, 2024 08:43
Base automatically changed from chore/remove-unused to develop November 14, 2024 06:35
@bang9 bang9 changed the title feat: rtl [AC-4189] feat: rtl Nov 25, 2024
@bang9 bang9 added the 1.9.0 label Nov 25, 2024
@bang9 bang9 requested a review from liamcho November 25, 2024 10:51
@bang9 bang9 marked this pull request as ready for review November 25, 2024 10:51
@bang9 bang9 changed the title [AC-4189] feat: rtl [AC-4189] feat: RTL Nov 25, 2024
@@ -48,7 +48,7 @@ function Banner() {
const { chatBottomContent } = useConstantState();

return (
<InnerContainer chatBottomBackgroundColor={chatBottomContent.backgroundColor}>
<InnerContainer chatBottomBackgroundColor={chatBottomContent.backgroundColor} dir={'ltr'}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is constant dir={'ltr'} intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a powered by sendbird banner
image

Copy link
Contributor

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bang9 bang9 merged commit b7d9007 into develop Nov 26, 2024
12 checks passed
@bang9 bang9 deleted the feat/rtl branch November 26, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants