Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conflicts with uikit #384

Merged
merged 3 commits into from
Nov 11, 2024
Merged

fix: conflicts with uikit #384

merged 3 commits into from
Nov 11, 2024

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented Nov 8, 2024

Changes

  • Use disconnectWebsocket instead of disconnect (applied changes from PR #1219)
  • Prevent changes to the theme if it has already been added by other logic.
  • Added localCacheEnabled flag to control the use of local cache in the Chat SDK.

ticket: AC-4281

Additional Notes

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

@bang9 bang9 requested a review from liamcho November 8, 2024 06:38
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit 8467aa3
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/673158652217310008a3d1b7
😎 Deploy Preview https://deploy-preview-384--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 8, 2024

Size Change: +115 B (+0.02%)

Total Size: 603 kB

Filename Size Change
./dist/__bundle-46d64517-********.js 4.01 kB +1 B (+0.02%)
./dist/__bundle-b5ef7de4-********.js 892 B +1 B (+0.11%)
./dist/index-********.js 306 kB +53 B (+0.02%)
./dist/index.es.js 174 B +1 B (+0.58%)
./dist/index.umd.js 283 kB +47 B (+0.02%)
./dist/Placeholder.error-********.js 346 B +3 B (+0.87%)
./dist/Placeholder.loading-********.js 186 B +3 B (+1.64%)
./dist/Placeholder.noChannels-********.js 184 B +2 B (+1.1%)
./dist/Placeholder.noMessages-********.js 184 B +1 B (+0.55%)
./dist/PlaceholderCommon-********.js 247 B +3 B (+1.23%)
ℹ️ View Unchanged
Filename Size
./dist/__bundle-7c3d40f4-********.js 21 B
./dist/style.css 8.62 kB

compressed-size-action

@bang9 bang9 changed the title fix: use disconnectWebsocket fix: conflicts with uikit Nov 11, 2024
@bang9 bang9 self-assigned this Nov 11, 2024
@bang9 bang9 added the 1.8.6 label Nov 11, 2024
Copy link
Contributor

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bang9 bang9 merged commit e0dd61a into develop Nov 11, 2024
11 checks passed
@bang9 bang9 deleted the fix/disconnect branch November 11, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants