Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SBTW-1940] Optimize Interactive Demo #374

Conversation

hello-mansoo
Copy link
Member

Changes

  • Add exception to prevent call when bodyInput is invalid (empty array or just include one object - bodyInput must includes 2 objects, role, and message)
  • Add apiHost props and type definition to adjust cdn api endpoint

ticket: []

Additional Notes

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

@hello-mansoo hello-mansoo self-assigned this Oct 10, 2024
src/components/Chat.tsx Outdated Show resolved Hide resolved
src/components/Chat.tsx Outdated Show resolved Hide resolved
@hello-mansoo hello-mansoo requested a review from bang9 October 11, 2024 01:49
@hello-mansoo
Copy link
Member Author

@bang9 위에 적어주신 커멘트 외에는 추가로 리뷰 주실 사항이 없지 않을까 예상되어, 먼저 머지하고 배포해 최적화가 잘 되었는지 모니터링 해 보고자 합니다.
혹시 추가로 리뷰를 주실 사항이 있다면 새롭게 브랜치 생성해서 추가로 대응할께요!
꼼꼼하게 봐 주셔서 감사해요, 아이렌:)

@hello-mansoo hello-mansoo merged commit 3f56cd5 into feat/interactive-demo/healthcare Oct 11, 2024
2 checks passed
@hello-mansoo hello-mansoo deleted the SBTW-1940-optimize-interactive-demo branch October 11, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants