Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-3468] feat: file message support #355

Merged
merged 14 commits into from
Sep 11, 2024
Merged

[AC-3468] feat: file message support #355

merged 14 commits into from
Sep 11, 2024

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented Sep 3, 2024

Changes

  • Added file message support

ticket: AC-3468

Additional Notes

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

@bang9 bang9 self-assigned this Sep 3, 2024
Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit 4f5a809
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/66e167183fb51b0008d68ea2
😎 Deploy Preview https://deploy-preview-355--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 3, 2024

Size Change: +7.75 kB (+1.31%)

Total Size: 602 kB

Filename Size Change
./dist/__bundle-46d64517-********.js 4.01 kB +2 B (+0.05%)
./dist/__bundle-91b5ecea-********.js 0 B -889 B (removed) 🏆
./dist/index-********.js 305 kB +3.88 kB (+1.29%)
./dist/index.es.js 173 B +3 B (+1.76%)
./dist/index.umd.js 282 kB +3.46 kB (+1.24%)
./dist/Placeholder.error-********.js 345 B -1 B (-0.29%)
./dist/Placeholder.loading-********.js 184 B -160 B (-46.51%) 🎉
./dist/Placeholder.noChannels-********.js 184 B +2 B (+1.1%)
./dist/Placeholder.noMessages-********.js 184 B +2 B (+1.1%)
./dist/PlaceholderCommon-********.js 246 B -1 B (-0.4%)
./dist/style.css 8.64 kB +568 B (+7.04%) 🔍
./dist/__bundle-bbedc09c-********.js 891 B +891 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
./dist/__bundle-7c3d40f4-********.js 21 B

compressed-size-action

@bang9 bang9 marked this pull request as draft September 3, 2024 02:31
@bang9 bang9 force-pushed the feat/file-support branch 6 times, most recently from 6e69c1b to c3ccd37 Compare September 6, 2024 04:32
@bang9 bang9 requested a review from liamcho September 9, 2024 06:03
@bang9 bang9 marked this pull request as ready for review September 9, 2024 06:03
package.json Show resolved Hide resolved
Copy link
Contributor

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-10 at 4 11 34 PM

요 기능은 PR에 없는거 같은데 포함 될 예정일까요?

@bang9
Copy link
Contributor Author

bang9 commented Sep 10, 2024

요 기능은 PR에 없는거 같은데 포함 될 예정일까요?

캡쳐된 스크린샷에 기능이 좀 많아서요! 어떤거 말씀하시는걸까요?! 파일 프리뷰 말씀하시는걸까여?

@liamcho
Copy link
Contributor

liamcho commented Sep 10, 2024

현재는 파일 selection 에서 선택하면 바로 file message 가 전송이 되는데 제가 찍은 스샷으로 이해하면 select 를 해도 바로 보내지지 않고 메세지 인풋창에 선택된 파일이 노출이 되고 text 메세지도 같이 보낼수 있는 ux 로 이해를 했습니다.

@bang9
Copy link
Contributor Author

bang9 commented Sep 10, 2024

현재는 파일 selection 에서 선택하면 바로 file message 가 전송이 되는데 제가 찍은 스샷으로 이해하면 select 를 해도 바로 보내지지 않고 메세지 인풋창에 선택된 파일이 노출이 되고 text 메세지도 같이 보낼수 있는 ux 로 이해를 했습니다.

네 맞습니다. 해당 기능은 PR 에 포함되어있습니다. 구현 자체는 UIKit 쪽 MessageInput 에 되어 있습니다.

@liamcho
Copy link
Contributor

liamcho commented Sep 11, 2024

packages/uikit 브랜치는 따로 없을까요? feat/file-support 브랜치의 chat-ai-widget/packages/uikit 경로는 ai-widget/experimental 으로 checkout 이 되있네요.

@bang9
Copy link
Contributor Author

bang9 commented Sep 11, 2024

packages/uikit 브랜치는 따로 없을까요? feat/file-support 브랜치의 chat-ai-widget/packages/uikit 경로는 ai-widget/experimental 으로 checkout 이 되있네요.

sendbird/sendbird-uikit-react@acc0713...db12d69#diff-92b0475a052f7ab7868cf176ae3f55a7d6f7c249d22688ea708f891b1e608e76
에서 보실 수 있습니다.

@liamcho
Copy link
Contributor

liamcho commented Sep 11, 2024

@bang9 넵 봤어요. 저는 로컬에서 직접 테스트해보고 싶은데 branch 만들어주실 수 있나요?

@bang9
Copy link
Contributor Author

bang9 commented Sep 11, 2024

@bang9 넵 봤어요. 저는 로컬에서 직접 테스트해보고 싶은데 branch 만들어주실 수 있나요?

ai-widget/file-support 브랜치 입니다. 리암의 로컬에서 서브모듈 헤드를 요기로 옮기시면 될거같아보입니당

Copy link
Contributor

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

## Changes
- Design QA changes

ticket: [AC-3788]

## Additional Notes
- 

## Checklist
Before requesting a code review, please check the following:
- [x] **[Required]** CI has passed all checks.
- [x] **[Required]** A self-review has been conducted to ensure there
are no minor mistakes.
- [x] **[Required]** Unnecessary comments/debugging code have been
removed.
- [x] **[Required]** All requirements specified in the ticket have been
accurately implemented.
- [ ] Ensure the ticket has been updated with the sprint, status, and
story points.


[AC-3788]:
https://sendbird.atlassian.net/browse/AC-3788?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@bang9 bang9 merged commit 8181ba9 into develop Sep 11, 2024
10 checks passed
@bang9 bang9 deleted the feat/file-support branch September 11, 2024 09:53
@bang9 bang9 added the 1.8.0 label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants