-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-3468] feat: file message support #355
Conversation
✅ Deploy Preview for chat-ai-widget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +7.75 kB (+1.31%) Total Size: 602 kB
ℹ️ View Unchanged
|
6e69c1b
to
c3ccd37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
캡쳐된 스크린샷에 기능이 좀 많아서요! 어떤거 말씀하시는걸까요?! 파일 프리뷰 말씀하시는걸까여? |
현재는 파일 selection 에서 선택하면 바로 file message 가 전송이 되는데 제가 찍은 스샷으로 이해하면 select 를 해도 바로 보내지지 않고 메세지 인풋창에 선택된 파일이 노출이 되고 text 메세지도 같이 보낼수 있는 ux 로 이해를 했습니다. |
네 맞습니다. 해당 기능은 PR 에 포함되어있습니다. 구현 자체는 UIKit 쪽 MessageInput 에 되어 있습니다. |
packages/uikit 브랜치는 따로 없을까요? feat/file-support 브랜치의 chat-ai-widget/packages/uikit 경로는 ai-widget/experimental 으로 checkout 이 되있네요. |
sendbird/sendbird-uikit-react@acc0713...db12d69#diff-92b0475a052f7ab7868cf176ae3f55a7d6f7c249d22688ea708f891b1e608e76 |
@bang9 넵 봤어요. 저는 로컬에서 직접 테스트해보고 싶은데 branch 만들어주실 수 있나요? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5afb47a
to
1dca3ea
Compare
## Changes - Design QA changes ticket: [AC-3788] ## Additional Notes - ## Checklist Before requesting a code review, please check the following: - [x] **[Required]** CI has passed all checks. - [x] **[Required]** A self-review has been conducted to ensure there are no minor mistakes. - [x] **[Required]** Unnecessary comments/debugging code have been removed. - [x] **[Required]** All requirements specified in the ticket have been accurately implemented. - [ ] Ensure the ticket has been updated with the sprint, status, and story points. [AC-3788]: https://sendbird.atlassian.net/browse/AC-3788?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Changes
ticket: AC-3468
Additional Notes
Checklist
Before requesting a code review, please check the following: