Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-3508] fix: update carousel index calculation #327

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented Aug 7, 2024

Changes

  • Bugfix for carousel index calculation

ticket: AC-3508

@bang9 bang9 self-assigned this Aug 7, 2024
@bang9 bang9 requested a review from AhyoungRyu August 7, 2024 04:30
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit 916ce75
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/66b2f858524a260008a0b260
😎 Deploy Preview https://deploy-preview-327--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bang9 bang9 requested a review from OnestarLee August 7, 2024 04:30
Copy link

github-actions bot commented Aug 7, 2024

Size Change: +19 B (0%)

Total Size: 618 kB

Filename Size Change
./dist/__bundle-2aa1a987-********.js 2.63 kB -1 B (-0.04%)
./dist/__bundle-347d730c-********.js 4.01 kB -1 B (-0.02%)
./dist/__bundle-95b1bd50-********.js 891 B -1 B (-0.11%)
./dist/index-********.js 312 kB +15 B (0%)
./dist/index.umd.js 291 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/index.es.js 171 B
./dist/style.css 7.95 kB

compressed-size-action

@bang9 bang9 added the 1.7.6 label Aug 7, 2024
Copy link

@OnestarLee OnestarLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

itemLength 나 itmeWidth 가 0일경우 의도하지 않은 동작이 발생할 가능성이 있을까요? @bang9

@bang9 bang9 changed the title fix: update carousel index calculation [AC-3508] fix: update carousel index calculation Aug 7, 2024
@bang9
Copy link
Contributor Author

bang9 commented Aug 7, 2024

itemLength 나 itmeWidth 가 0일경우 의도하지 않은 동작이 발생할 가능성이 있을까요? @bang9

0 이면 아무것도 렌더링이 되지 않을거라서 동작할 컴포넌트가 없으므로, 괜찮을 것 같습니다!

@bang9 bang9 merged commit 09587e1 into develop Aug 7, 2024
10 checks passed
@bang9 bang9 deleted the fix/carousel-indexing branch August 7, 2024 05:51
@bang9 bang9 added the 1.7.7 label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants