Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typing indicator bubble to depend on bot user typing status update #318

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented Jul 29, 2024

@liamcho liamcho requested a review from bang9 July 29, 2024 04:06
@liamcho liamcho self-assigned this Jul 29, 2024
Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit 66accb1
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/66a716d56480fe00084a04fc
😎 Deploy Preview https://deploy-preview-318--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jul 29, 2024

Size Change: +176 B (+0.03%)

Total Size: 618 kB

Filename Size Change
./dist/__bundle-2aa1a987-********.js 2.63 kB +3 B (+0.11%)
./dist/__bundle-347d730c-********.js 4.01 kB +1 B (+0.02%)
./dist/__bundle-95b1bd50-********.js 893 B +2 B (+0.22%)
./dist/index-********.js 312 kB +104 B (+0.03%)
./dist/index.es.js 173 B +3 B (+1.76%)
./dist/index.umd.js 290 kB +63 B (+0.02%)
ℹ️ View Unchanged
Filename Size
./dist/style.css 7.95 kB

compressed-size-action

@bang9
Copy link
Contributor

bang9 commented Jul 29, 2024

Is it okay if I handle it in #312 ? There will be conflicts related to this, so I'll make the changes together

@bang9
Copy link
Contributor

bang9 commented Jul 29, 2024

7a26bee

When the message status is pending, the typing bubble doesn't appear because the message hasn't reached the server yet, even if it's just for a brief moment.

Since there is a subtle difference, I won't apply it immediately. It would be better to test whether the user experience is natural after implementing the display of the pending status, and then apply it if it works well.

@liamcho
Copy link
Contributor Author

liamcho commented Jul 31, 2024

Is it okay if I handle it in #312 ? There will be conflicts related to this, so I'll make the changes together

yes!

@liamcho liamcho closed this Jul 31, 2024
@liamcho
Copy link
Contributor Author

liamcho commented Jul 31, 2024

7a26bee

When the message status is pending, the typing bubble doesn't appear because the message hasn't reached the server yet, even if it's just for a brief moment.

Since there is a subtle difference, I won't apply it immediately. It would be better to test whether the user experience is natural after implementing the display of the pending status, and then apply it if it works well.

We still needs this for auto-resend.

@bang9
Copy link
Contributor

bang9 commented Jul 31, 2024

7a26bee
When the message status is pending, the typing bubble doesn't appear because the message hasn't reached the server yet, even if it's just for a brief moment.
Since there is a subtle difference, I won't apply it immediately. It would be better to test whether the user experience is natural after implementing the display of the pending status, and then apply it if it works well.

We still needs this for auto-resend.

That is block logic, not related to this(typing bubble).

@bang9 bang9 deleted the fix/AC-3394-fix-typing-indicator-bubble-to-depend-on-typing-update-event branch August 1, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants