Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update submodule #262

Merged
merged 1 commit into from
Jun 4, 2024
Merged

chore: update submodule #262

merged 1 commit into from
Jun 4, 2024

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented Jun 3, 2024 •
edited by bang9
Loading

  • remove auto focus

@liamcho liamcho added the 1.6.2 label Jun 3, 2024
@liamcho liamcho requested a review from bang9 June 3, 2024 15:40
@liamcho liamcho self-assigned this Jun 3, 2024
@bang9
Copy link
Contributor

bang9 commented Jun 3, 2024

sendbird/sendbird-uikit-react#1122
@liamcho 브랜치 관리가 제대로 안되는것 같습니다 ㅜㅜ 어프루브 한 시점하고 머지된 내용이 다르기도 하구요, 이렇게 작업되면 PR 리뷰하는 입장에서 왜 이렇게 변경사항이 만들어진건지 혼란스럽고 직접 브랜치를 일일이 체크를 해봐야합니다.
image

@liamcho
Copy link
Contributor Author

liamcho commented Jun 4, 2024

넵 죄송합니다, 머지전에 실수로 ai-widget/experimental 브랜치에서 yarn.lock 파일을 커밋 ("Remove auto focus message input on user given disabled state set to false") 해서 생긴 이슈입니다. fix/AC-2593-remove-auto-focus-message-input-on-enable 브랜치에서 했어야 했는데 실수했습니다. 재발하지 않도록 조심하겠습니다 🙏

Screenshot 2024-06-04 at 10 10 11 AM

@bang9 bang9 merged commit c547880 into develop Jun 4, 2024
@bang9 bang9 deleted the chore/update-submodule branch June 4, 2024 02:05
@bang9 bang9 added 1.6.1 and removed 1.6.2 labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bang9 bang9 bang9 approved these changes

Assignees

@liamcho liamcho

Labels
1.6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamcho @bang9