[AC-1971]: Use git submodule for uikit-react to reduce the bundle size #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhyoungRyu
commented
Apr 29, 2024
AhyoungRyu
changed the title
AhyoungRyu
commented
Apr 29, 2024
| @@ -1,7 +1,7 @@ | |||
| import styled from 'styled-components'; | |||
|
|
|||
| import { getColorBasedOnSaturation } from '../colors'; | |||
| import { ReactComponent as Icon } from '../icons/bot-profile-image-small.svg'; | |||
There was a problem hiding this comment.
Why this format have to be changed?
- Verbose to use
- It causes a conflict with UIKit svg import type and throwing an error 🥲
AhyoungRyu
force-pushed
the
feat/tree-shaking
branch
3 times, most recently
from
e7c8bdc to
c3677ef
Compare
liamcho
reviewed
Apr 30, 2024
| parserOptions: { | ||
| ecmaVersion: 'latest', | ||
| sourceType: 'module', | ||
| ecmaFeatures: { jsx: true }, |
There was a problem hiding this comment.
jsx: ECMScript 규격의 JSX 사용 여부
^ is this relevant to reducing bundle size?
There was a problem hiding this comment.
Size reduce related? Not really but added in terms of better practice? \cc @bang9
There was a problem hiding this comment.
before adding this was there an issue?
There was a problem hiding this comment.
I directly linked UIKit and set up path aliases, ensuring that files are processed correctly in ESLint as well.
But I can't remember why ecmaFeatures: { jsx: true } was enabled. 🙄
liamcho
reviewed
Apr 30, 2024
liamcho
reviewed
Apr 30, 2024
liamcho
reviewed
Apr 30, 2024
liamcho
reviewed
Apr 30, 2024
liamcho
reviewed
Apr 30, 2024
liamcho
reviewed
Apr 30, 2024
liamcho
reviewed
Apr 30, 2024
liamcho
reviewed
Apr 30, 2024
Yes :) |
bang9
reviewed
Apr 30, 2024
bang9
approved these changes
Apr 30, 2024
* feat: connect on ChatAiWidget component mounting * remove sdkInitParam * Add comment about localStorage custom event * Disconnect WS connection after 3min elapsed and reconnect on clicking widget button * Disconnect WS connection after 3min elapsed and reconnect on clicking widget button * SBComponent -> ProviderContainer * Set defaultValue to useWidgetLocalStorage to prevent null reference error * Create a separate WidgetWindowExternal * Remove unnecessary type assertion * Handle isWidgetOpen via Provider * Split mobile & desktop component
AhyoungRyu
force-pushed
the
feat/tree-shaking
branch
from
2d02b80 to
e6620e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes:
@sendbird/uikit-reactdependency frompackage.json.packages/uikit/dir through a Git submodule. <- See.gitmodulesfileSo how much of the bundle size would be reduced?
AS-IS
TO-BE
