Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldnt Product Clicked event be mapped as select_item instead of select_content? #90

Closed
fhdeodato opened this issue Jun 19, 2024 · 1 comment

Comments

@fhdeodato
Copy link

Hello,

thanks for the amazing plugin =)

I was reviewing the Firebase integration and looks like the plugin translates the event Product Clicked to Firebase select_content one.

but we have a recommended events when the user clicks a product that is the select_item.

Which makes think that we should change it because, since the event is specific for "Products".

this event already exists in the firebase package

https://github.com/firebase/flutterfire/blob/master/packages/firebase_analytics/firebase_analytics/lib/src/firebase_analytics.dart#L828

Is there any reason that is mapped using the select_content? it is important to know before sending a PR

Thanks for the help

@edsonjab
Copy link
Contributor

Hi @fhdeodato thank you for your report, looks like we have a mistake on that method, it makes sense that the Product Clicked will be select_item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants