New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Derive symmetric key correctly #218

Merged

Sn0wfreezeDev merged 1 commit into seemoo-lab:main from freak4pc:symmetric-key-derivation

Oct 16, 2023

Contributor

freak4pc commented Oct 16, 2023

I discussed this with @Sn0wfreezeDev privately,

When deriving symmetric keys, the code was always deriving from the root symmetric key instead of deriving from the oldest relevant symmetric key.

This produced the same symmetric key over and over and over instead of deriving new rolling ones.

Thanks to @ThatFatPat for helping me debug this 🚀


          [fix] Derive symmetric key correctly

6a5a71c

Member

Sn0wfreezeDev commented Oct 16, 2023

Thanks a lot for discovering that issue. Happy to accept your PR 😊

Sn0wfreezeDev merged commit 7d72fa1 into seemoo-lab:main

2 of 3 checks passed

freak4pc deleted the symmetric-key-derivation branch

October 16, 2023 19:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet