diff --git a/.changeset/breezy-eagles-perform.md b/.changeset/breezy-eagles-perform.md new file mode 100644 index 000000000..688218386 --- /dev/null +++ b/.changeset/breezy-eagles-perform.md @@ -0,0 +1,5 @@ +--- +'wingman-fe': patch +--- + +Remove deprecated `dividers` in Braid components diff --git a/.eslintignore b/.eslintignore index c65292cfc..d1a4a5170 100644 --- a/.eslintignore +++ b/.eslintignore @@ -4,6 +4,7 @@ .prettierrc coverage/ dist/ +pnpm-lock.yaml report/ tsconfig.json # end managed by sku diff --git a/.prettierignore b/.prettierignore index acba15a6b..d1a4a5170 100644 --- a/.prettierignore +++ b/.prettierignore @@ -4,8 +4,7 @@ .prettierrc coverage/ dist/ +pnpm-lock.yaml report/ tsconfig.json # end managed by sku - -pnpm-lock.yaml diff --git a/fe/example/src/App/Sidebar.tsx b/fe/example/src/App/Sidebar.tsx index 0c220833a..42a02bf5f 100644 --- a/fe/example/src/App/Sidebar.tsx +++ b/fe/example/src/App/Sidebar.tsx @@ -1,5 +1,6 @@ import { Box, + Divider, Heading, IconEducation, IconHome, @@ -65,18 +66,18 @@ const SidebarLink = ({ children, size, to }: SidebarLinkProps) => { export const Sidebar = () => ( - + 🛩 - - + + Home - + {/* TODO: rebuild from shared components. */} {/* diff --git a/fe/example/src/components/RichDropdown.tsx b/fe/example/src/components/RichDropdown.tsx index 4ad0c7ee4..f301ce3d0 100644 --- a/fe/example/src/components/RichDropdown.tsx +++ b/fe/example/src/components/RichDropdown.tsx @@ -1,4 +1,4 @@ -import { Box, IconChevron, Stack } from 'braid-design-system'; +import { Box, Divider, IconChevron, Stack } from 'braid-design-system'; import React, { type ReactNode, useState } from 'react'; import * as styles from './RichDropdown.css'; @@ -55,11 +55,14 @@ export const RichDropdown = ({ }; return expanded ? ( - - {values.map((value) => ( - select(value)} value={value}> - {children} - + + {values.map((value, index) => ( + + {index > 0 ? : null} + select(value)} value={value}> + {children} + + ))} ) : ( diff --git a/fe/example/src/pages/Admin/Admin.tsx b/fe/example/src/pages/Admin/Admin.tsx index 7980c7688..56f0a781b 100644 --- a/fe/example/src/pages/Admin/Admin.tsx +++ b/fe/example/src/pages/Admin/Admin.tsx @@ -1,4 +1,10 @@ -import { Box, ContentBlock, Heading, Stack } from 'braid-design-system'; +import { + Box, + ContentBlock, + Divider, + Heading, + Stack, +} from 'braid-design-system'; import React from 'react'; import { ClientOnly } from '../../components/ClientOnly'; @@ -10,11 +16,11 @@ import { Version } from './Version'; import { Webhook } from './Webhook'; export const AdminPage = () => ( - +
Admin
- + diff --git a/fe/example/src/pages/Admin/Attachments.tsx b/fe/example/src/pages/Admin/Attachments.tsx index be523c517..bf35a6041 100644 --- a/fe/example/src/pages/Admin/Attachments.tsx +++ b/fe/example/src/pages/Admin/Attachments.tsx @@ -1,4 +1,4 @@ -import { Card, Heading, List, Stack, Text } from 'braid-design-system'; +import { Card, Divider, Heading, List, Stack, Text } from 'braid-design-system'; import React from 'react'; import { useBrowserToken } from '../../../../lib/hooks'; @@ -16,9 +16,9 @@ export const Attachments = () => { return ( - + Attachments - + { return ( - + User - + { return ( - + Version - + {typeof version === 'undefined' ? : version} diff --git a/fe/example/src/pages/Admin/Webhook.tsx b/fe/example/src/pages/Admin/Webhook.tsx index 3a0c5723a..c2d7ab8ef 100644 --- a/fe/example/src/pages/Admin/Webhook.tsx +++ b/fe/example/src/pages/Admin/Webhook.tsx @@ -2,6 +2,7 @@ import { Actions, Button, Card, + Divider, Heading, Stack, useToast, @@ -57,9 +58,9 @@ export const Webhook = () => { return ( - + Webhook - + - + { {candidate.notes.length ? ( - + {candidate.notes.map((note, index) => ( - - - - {note.author.formattedName} ·{' '} - - - - {note.text} - + + {index > 0 ? : null} + + + + {note.author.formattedName} ·{' '} + + + + {note.text} + + ))} diff --git a/fe/example/src/pages/Candidates/Detail/Profile.tsx b/fe/example/src/pages/Candidates/Detail/Profile.tsx index edf5430c1..4c7f3567f 100644 --- a/fe/example/src/pages/Candidates/Detail/Profile.tsx +++ b/fe/example/src/pages/Candidates/Detail/Profile.tsx @@ -42,13 +42,17 @@ interface Props { export const CandidateProfile = ({ children: candidate }: Props) => ( - + Career history {candidate.roles.length ? undefined : ( - - New to the workforce - + <> + + + + New to the workforce + + )} {candidate.roles @@ -57,33 +61,42 @@ export const CandidateProfile = ({ children: candidate }: Props) => ( candidate.roles.length === MAX_ROLES ? MAX_ROLES : MAX_ROLES - 1, ) .map((role, index) => ( - {role} + + + {role} + ))} {candidate.roles.length > MAX_ROLES ? ( - - - - - - {candidate.roles.slice(MAX_ROLES - 1).map((role, index) => ( - {role} - ))} + <> + + + + + + + {candidate.roles.slice(MAX_ROLES - 1).map((role, index) => ( + + {index > 0 ? : null} + {role} + + ))} + - - + + ) : undefined} {candidate.qualifications.length ? ( - + Education - + {candidate.qualifications.map((qualification, index) => ( @@ -102,9 +115,9 @@ export const CandidateProfile = ({ children: candidate }: Props) => ( {candidate.skills.length ? ( - + Skills - + {candidate.skills.map((skill, index) => ( {skill.name} diff --git a/fe/example/src/pages/Candidates/List.tsx b/fe/example/src/pages/Candidates/List.tsx index 132271a5a..dd3c62da2 100644 --- a/fe/example/src/pages/Candidates/List.tsx +++ b/fe/example/src/pages/Candidates/List.tsx @@ -1,4 +1,4 @@ -import { Heading, Stack } from 'braid-design-system'; +import { Divider, Heading, Stack } from 'braid-design-system'; import React from 'react'; import { Header } from '../../components/Header'; @@ -6,11 +6,11 @@ import { CANDIDATES } from '../../data/candidates'; import { CandidateList } from '../../widgets/CandidateList'; export const CandidateListPage = () => ( - +
Candidates
- + {/* TODO: support pagination */}
diff --git a/fe/example/src/pages/Home.tsx b/fe/example/src/pages/Home.tsx index cec0c38c5..ba57474b5 100644 --- a/fe/example/src/pages/Home.tsx +++ b/fe/example/src/pages/Home.tsx @@ -1,15 +1,22 @@ -import { Box, ContentBlock, Heading, Stack, Text } from 'braid-design-system'; +import { + Box, + ContentBlock, + Divider, + Heading, + Stack, + Text, +} from 'braid-design-system'; import React from 'react'; import { SmartTextLink } from 'scoobie'; import { Header } from '../components/Header'; export const HomePage = () => ( - +
🚧
- + ( - +
Oops!
- + diff --git a/fe/example/src/pages/Positions/Detail.tsx b/fe/example/src/pages/Positions/Detail.tsx index 2e5140512..57fc037cd 100644 --- a/fe/example/src/pages/Positions/Detail.tsx +++ b/fe/example/src/pages/Positions/Detail.tsx @@ -2,6 +2,7 @@ import { Badge, Box, ContentBlock, + Divider, Heading, IconPeople, IconVisibility, @@ -154,7 +155,7 @@ const PositionDetails = () => { const candidates = CANDIDATES_BY_POSITION_ID[position.id]; return ( - +
@@ -168,7 +169,7 @@ const PositionDetails = () => {
- + {preferences.devTools ? ( @@ -203,6 +204,7 @@ const PositionDetails = () => { + ( - +
Positions
- + { // TODO: support pagination diff --git a/fe/example/src/pages/Positions/New.tsx b/fe/example/src/pages/Positions/New.tsx index 2773642cd..fe41fcfa0 100644 --- a/fe/example/src/pages/Positions/New.tsx +++ b/fe/example/src/pages/Positions/New.tsx @@ -1,4 +1,10 @@ -import { Box, ContentBlock, Heading, Stack } from 'braid-design-system'; +import { + Box, + ContentBlock, + Divider, + Heading, + Stack, +} from 'braid-design-system'; import React from 'react'; import { Breadcrumbs } from '../../components/Breadcrumbs'; @@ -7,7 +13,7 @@ import { Header } from '../../components/Header'; import { NewPositionForm } from '../../widgets/NewPositionForm'; export const PositionNewPage = () => ( - +
@@ -21,7 +27,7 @@ export const PositionNewPage = () => (
- + diff --git a/fe/example/src/pages/Positions/Questionnaires.tsx b/fe/example/src/pages/Positions/Questionnaires.tsx index a173bbe63..3225ad96f 100644 --- a/fe/example/src/pages/Positions/Questionnaires.tsx +++ b/fe/example/src/pages/Positions/Questionnaires.tsx @@ -3,6 +3,7 @@ import { Box, Button, ContentBlock, + Divider, Heading, Stack, } from 'braid-design-system'; @@ -17,11 +18,11 @@ export const PositionQuestionnairePage = () => { const [selection, setSelection] = useState(); return ( - +
Questionnaires
- + diff --git a/fe/example/src/widgets/NewPositionForm.tsx b/fe/example/src/widgets/NewPositionForm.tsx index c319f3c19..605b37f84 100644 --- a/fe/example/src/widgets/NewPositionForm.tsx +++ b/fe/example/src/widgets/NewPositionForm.tsx @@ -4,6 +4,7 @@ import { Button, Card, Checkbox, + Divider, Heading, Notice, Stack, @@ -30,7 +31,7 @@ export const NewPositionForm = () => { }); return ( - + { /> - + Advertise your position @@ -85,8 +86,13 @@ export const NewPositionForm = () => { - {seekAd ? : undefined} - + {seekAd ? ( + <> + + + + ) : undefined} +