Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 22 support #1549

Open
11 of 17 tasks
AaronMoat opened this issue Apr 25, 2024 · 5 comments · May be fixed by #1735
Open
11 of 17 tasks

Node 22 support #1549

AaronMoat opened this issue Apr 25, 2024 · 5 comments · May be fixed by #1735
Assignees
@zbrydon

Comments

@AaronMoat
Copy link
Contributor

AaronMoat commented Apr 25, 2024 •
edited by zbrydon
Loading

Issue to track when we're ready to support Node 22 https://nodejs.org/en/blog/announcements/v22-release-announce. Add to the list as you find things:

  • Promoted from Current to LTS
  • AWS Lambda support, including via CDK
  • Serverless supported or migration path to CDK documented
  • skuba migrate node22 written
  • deps: @types/node ^22.0.0 #1665 restored
  • .node-version
  • .nvmrc
  • package.json @types/node
  • package.json engine (this one might be tricky, if we detect you publish packages, we might leave this alone)
  • serverless*.y*ml files
  • CDK files. (This night be tricky due to naming but potentially scan through infra/*.ts files. Might do a quick scan through other teams repos.
  • docker-compose*.yml
  • Dockerfile*
  • Tsconfig target (TS 5.7 will support ES2024, Node 22 essentially fully supports ES2024 but once again might bail if we think you're publishing a package) https://node.green/#ES2024
  • GH Actions workflows
  • Handle shas
  • Handle public.ecr.aws/docker/library/node
@AaronMoat
Copy link
Contributor Author

AaronMoat commented Aug 10, 2024 •
edited
Loading

https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

The following list shows the target launch month for upcoming Lambda runtimes. These dates are indicative only and subject to change.

Node.js 22 - November 2024

@samchungy
Copy link
Contributor

samchungy commented Sep 10, 2024 •
edited
Loading

Bundle with: #1655 (comment)

@samchungy
Copy link
Contributor

General consensus is we want an autofix :)

https://seekchat.slack.com/archives/CDCPCEPV3/p1730239722171889

@AaronMoat AaronMoat removed the blocked label Nov 11, 2024
@zbrydon
Copy link
Contributor

zbrydon commented Nov 13, 2024

#1735

@zbrydon zbrydon linked a pull request Nov 13, 2024 that will close this issue
Draft
@samchungy
Copy link
Contributor

Depends on: #1750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zbrydon zbrydon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

skuba migrate node 22 seek-oss/skuba
3 participants
@AaronMoat @samchungy @zbrydon