Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Warm Step/Build Cache" ECR Step #1333

Open
samchungy opened this issue Dec 11, 2023 · 1 comment
Open

Remove "Warm Step/Build Cache" ECR Step #1333

samchungy opened this issue Dec 11, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@samchungy
Copy link
Contributor

Through testing with pnpm on a number of my team's repos. I found that installing the deps per step without a cache step was in most cases quicker/almost the same amount of time as pulling from ECR.

When/if the build agency folks add a persistent EFS between build agents, this would completely forego the need for ECR as the cache. If this happens, we can utilise Docker's cache mounting and finally reap the full benefits of the pnpm store.

RUN --mount=type=cache,id=pnpm,target=/pnpm/store pnpm install --prod --frozen-lockfile
@samchungy samchungy added the enhancement New feature or request label Dec 11, 2023
@72636c
Copy link
Member

72636c commented Dec 11, 2023

I think I could be convinced to do this once we land #1289; I'd have concerns around depending that heavily on the Yarn mirror to rebuild in a DR scenario given past flakiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants