From b7d15713e9f8815be678d98d8df934d670e103f6 Mon Sep 17 00:00:00 2001 From: Ryan Ling Date: Thu, 4 May 2023 11:04:05 +1000 Subject: [PATCH] template: Include manifest files in CODEOWNERS (#1162) As raised by @askoufis on Slack. --- .changeset/dry-suns-relate.md | 17 +++++++++++++++++ template/base/.github/CODEOWNERS | 4 ---- 2 files changed, 17 insertions(+), 4 deletions(-) create mode 100644 .changeset/dry-suns-relate.md diff --git a/.changeset/dry-suns-relate.md b/.changeset/dry-suns-relate.md new file mode 100644 index 000000000..55763e2e0 --- /dev/null +++ b/.changeset/dry-suns-relate.md @@ -0,0 +1,17 @@ +--- +'skuba': patch +--- + +template: Include manifest files in CODEOWNERS + +Our templates previously excluded `package.json` and `yarn.lock` from CODEOWNERS. This was intended to support advanced workflows such as auto-merging PRs and augmenting GitHub push notifications with custom tooling. However, we are reverting this configuration as it is more common for SEEKers to prefer a simpler CODEOWNERS-based workflow. + +This will not affect existing projects. If you create a new project and wish to restore the previous behaviour, you can manually extend `.github/CODEOWNERS`: + +```diff +* @<%- ownerName %> + ++ # Configured by Renovate ++ package.json ++ yarn.lock +``` diff --git a/template/base/.github/CODEOWNERS b/template/base/.github/CODEOWNERS index 7678780db..3df268fbe 100644 --- a/template/base/.github/CODEOWNERS +++ b/template/base/.github/CODEOWNERS @@ -1,5 +1 @@ * @<%- ownerName %> - -# Configured by Renovate -package.json -yarn.lock