From 5cfcb70c8491eafe83954ebd3781855b388ccb3b Mon Sep 17 00:00:00 2001 From: Aaron Moat <2937187+AaronMoat@users.noreply.github.com> Date: Fri, 20 Dec 2024 15:06:09 +1100 Subject: [PATCH] Drop support for `failOnScanFindings` for gantry 4 support (#1759) --- .changeset/tender-ducks-rescue.md | 5 +++++ template/express-rest-api/gantry.build.yml | 3 --- template/koa-rest-api/gantry.build.yml | 3 --- 3 files changed, 5 insertions(+), 6 deletions(-) create mode 100644 .changeset/tender-ducks-rescue.md diff --git a/.changeset/tender-ducks-rescue.md b/.changeset/tender-ducks-rescue.md new file mode 100644 index 000000000..37b820e13 --- /dev/null +++ b/.changeset/tender-ducks-rescue.md @@ -0,0 +1,5 @@ +--- +'skuba': patch +--- + +template/express-rest-api, template/koa-rest-api: Drop support for `failOnScanFindings` for gantry 4 support diff --git a/template/express-rest-api/gantry.build.yml b/template/express-rest-api/gantry.build.yml index d410dde3c..f972d3a36 100644 --- a/template/express-rest-api/gantry.build.yml +++ b/template/express-rest-api/gantry.build.yml @@ -8,7 +8,4 @@ buildArgs: # https://github.com/seek-oss/docker-ecr-cache-buildkite-plugin#building-on-the-resulting-image BASE_IMAGE: '{{.Env.BUILDKITE_PLUGIN_DOCKER_ECR_CACHE_EXPORT_IMAGE}}:{{.Env.BUILDKITE_PLUGIN_DOCKER_ECR_CACHE_EXPORT_TAG}}' -# SEEK-Jobs/gantry#1661 -failOnScanFindings: false - cpuArchitecture: <%- platformName %> diff --git a/template/koa-rest-api/gantry.build.yml b/template/koa-rest-api/gantry.build.yml index d410dde3c..f972d3a36 100644 --- a/template/koa-rest-api/gantry.build.yml +++ b/template/koa-rest-api/gantry.build.yml @@ -8,7 +8,4 @@ buildArgs: # https://github.com/seek-oss/docker-ecr-cache-buildkite-plugin#building-on-the-resulting-image BASE_IMAGE: '{{.Env.BUILDKITE_PLUGIN_DOCKER_ECR_CACHE_EXPORT_IMAGE}}:{{.Env.BUILDKITE_PLUGIN_DOCKER_ECR_CACHE_EXPORT_TAG}}' -# SEEK-Jobs/gantry#1661 -failOnScanFindings: false - cpuArchitecture: <%- platformName %>