Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: modify Konflux pipelines #745

Merged
merged 1 commit into from
Nov 13, 2024
Merged

ci: modify Konflux pipelines #745

merged 1 commit into from
Nov 13, 2024

Conversation

osmman
Copy link
Contributor

@osmman osmman commented Nov 12, 2024

Migrated Konflux pipeline based on OLM operator example

https://github.com/konflux-ci/olm-operator-konflux-sample

@openshift-ci openshift-ci bot requested review from bouskaJ and lance November 12, 2024 15:40
@osmman osmman force-pushed the tturek/tekton branch 4 times, most recently from d07915a to 472582e Compare November 12, 2024 16:21
@osmman
Copy link
Contributor Author

osmman commented Nov 13, 2024

/override "Test upgrade operator"

Copy link

openshift-ci bot commented Nov 13, 2024

@osmman: Overrode contexts on behalf of osmman: Test upgrade operator

In response to this:

/override "Test upgrade operator"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tommyd450
Copy link
Contributor

@osmman is there a reason you are chaining the pipelines? Rather than having them be in the one tekton file? Im also going to re run Konflux builds as the tasks on Konflux are not reporting much .

@tommyd450
Copy link
Contributor

/retest

@osmman
Copy link
Contributor Author

osmman commented Nov 13, 2024

@osmman is there a reason you are chaining the pipelines? Rather than having them be in the one tekton file? Im also going to re run Konflux builds as the tasks on Konflux are not reporting much .

I’m chaining the pipelines to avoid duplicating code for push and pull_request pipelines. This approach makes it easier to add new steps, like unit tests, in future updates. I followed the Konflux example for this setup.

There has been added new step to build-image-index which enable to have images for multiple architectures.

@osmman osmman closed this Nov 13, 2024
@osmman osmman reopened this Nov 13, 2024
Copy link

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osmman, tommyd450

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b463d02 into main Nov 13, 2024
18 checks passed
@osmman osmman deleted the tturek/tekton branch November 13, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants