[SECURESIGN-663] Add option to set an external ctlog service #465
Conversation
fghanmi
force-pushed
the
SECURESIGN-663
branch
2 times, most recently
from
562c9b6 to
5386ad4
Compare
| case instance.Spec.Ctlog.Port == nil && instance.Spec.Ctlog.Address != "": | ||
| err = fmt.Errorf("%w", CtlogPortNotSpecified) | ||
| case instance.Spec.Ctlog.Address == "": | ||
| ctlogUrl = fmt.Sprintf("http://ctlog.%s.svc/trusted-artifact-signer", instance.Namespace) |
There was a problem hiding this comment.
We can extract https://github.com/securesign/secure-sign-operator/blob/main/internal/controller/ctlog/utils/ctlog_config.go#L177 to constant and reuse for better transparency. (it is not clear from where the URL suffix is getting there).
| var err error | ||
| var ctlogUrl string | ||
| switch { | ||
| case instance.Spec.Ctlog.Port == nil && instance.Spec.Ctlog.Address != "": |
There was a problem hiding this comment.
operator will fails on fatal error if port is nil and address has any non empty value. It will unable to dereference *instance.Spec.Ctlog.Port value if it is nil.
Please do that same way as rekor deployment.
|
Please run |
fghanmi
force-pushed
the
SECURESIGN-663
branch
10 times, most recently
from
317e8e8 to
5151079
Compare
fghanmi
force-pushed
the
SECURESIGN-663
branch
4 times, most recently
from
ab5cd59 to
88cb767
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fghanmi, osmman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.