Migrate from phases to conditions #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouskaJ
force-pushed
the
migrate_to_conditions
branch
3 times, most recently
from
a1e343c to
6aadc07
Compare
bouskaJ
force-pushed
the
migrate_to_conditions
branch
from
6aadc07 to
ae74769
Compare
bouskaJ
force-pushed
the
migrate_to_conditions
branch
from
be7c1a4 to
09f781f
Compare
osmman
reviewed
Feb 15, 2024
osmman
reviewed
Feb 15, 2024
osmman
reviewed
Feb 15, 2024
cooktheryan
reviewed
Feb 15, 2024
| } | ||
|
|
||
| type SecuresignTufStatus struct { | ||
| Url string `json:"url,omitempty"` | ||
| } | ||
|
|
There was a problem hiding this comment.
do we need a trillian type?
There was a problem hiding this comment.
I don't think so, I exposed fulcio, tuf and rekor because they provide URL for users. Trillian is just a backend service that is never touched by end user.
osmman
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #34