From 5b25fd406296d6f17679e4232ecb5e081c533072 Mon Sep 17 00:00:00 2001 From: David Moises Paz Reyes Date: Mon, 11 May 2015 10:50:52 +0200 Subject: [PATCH 1/2] Ignore bin/ directory After making `composer install` got bin dir created. This is nice to have but disturb on commit time since need to care not include bin folder on commit. --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index aabf95d8..09ee990d 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,4 @@ cache.properties composer.lock phpunit.xml vendor +bin \ No newline at end of file From d973c5c507be654c8bd07d965ed3751bf13f636e Mon Sep 17 00:00:00 2001 From: David Moises Paz Reyes Date: Mon, 11 May 2015 10:53:35 +0200 Subject: [PATCH 2/2] Add full error description to exception When debugging the xml data there is more information about error than just the message. Knowing line number can be useful. --- PHPUnit/Extensions/Database/DataSet/AbstractXmlDataSet.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PHPUnit/Extensions/Database/DataSet/AbstractXmlDataSet.php b/PHPUnit/Extensions/Database/DataSet/AbstractXmlDataSet.php index 74b21ce8..32e0884b 100644 --- a/PHPUnit/Extensions/Database/DataSet/AbstractXmlDataSet.php +++ b/PHPUnit/Extensions/Database/DataSet/AbstractXmlDataSet.php @@ -52,7 +52,7 @@ public function __construct($xmlFile) $message = ''; foreach (libxml_get_errors() as $error) { - $message .= $error->message; + $message .= print_r($error, true); } throw new RuntimeException($message);