Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown gets stuck sometimes #51

Open
sebadob opened this issue Oct 28, 2024 · 0 comments
Open

Shutdown gets stuck sometimes #51

sebadob opened this issue Oct 28, 2024 · 0 comments

Comments

@sebadob
Copy link
Owner

sebadob commented Oct 28, 2024

This is one of the known issues I mentioned in the readme.

The Client::shutdown() can get stuck at the very last step. I have not found a reason for this yet. Because this is just a tokio::time::sleep().await, which is something where it should never be able to even get stuck at all, I am not sure if the reason has to do something with the test setup, because I did not see it in production for a long time after some tweaks to the shutdown routine.

If you however see hiqlite getting stuck on shutdown, please let me know about this.
I have added info logs after each of the shutdown steps for better debugging this in the wild, until it is solved.

In tests, while the test context is confusing sometimes because it shares static memory and so on (everything is started from the same process), the very last log entry from the procedure is

hiqlite::client::mgmt: Waiting 5 additional seconds before shutting down

If someone sees this and it still does not shut down after 5 seconds, this may be a tokio bug somehow. Please let me know in this case.

@sebadob sebadob added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant