From 7aedb5c2400261259781f5a9da13511d39f4fc84 Mon Sep 17 00:00:00 2001 From: Zaim Date: Thu, 25 Apr 2019 10:46:42 +0800 Subject: [PATCH 1/5] docs(readme): testing readme update --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 85cde98b7..15e6dd8c6 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ [![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/) [![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release) -This is a set of react components which some of them are based on SEB's bootstrap. The plan for this project is to increase and improve components for future usages. +This is a set of react components which some of them are based on SEB's bootstrap. The plan for this project is to increase and improve components for future usages - The package name: `@sebgroup/react-components` - The package documentation: [Documentation](https://sebgroup.github.io/react-components) From e6964e455aee2a38701346a09cfb039eba927ce2 Mon Sep 17 00:00:00 2001 From: Robert Hjalmers Date: Thu, 25 Apr 2019 09:30:01 +0200 Subject: [PATCH 2/5] ci: use latest LTS release of node.js --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index ccd656c21..9802f445c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,10 +3,10 @@ sudo: false addons: chrome: stable language: node_js -node_js: node +node_js: lts/* install: -- npm install +- npm ci cache: directories: - $HOME/.npm From 95ef5f1f61d7a25bbbf27e0d0dfbabb5e7634208 Mon Sep 17 00:00:00 2001 From: Yousif Al-Raheem Date: Fri, 3 May 2019 18:53:29 +0800 Subject: [PATCH 3/5] Update issue templates --- .github/ISSUE_TEMPLATE/bug_report.md | 38 +++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 20 ++++++++++++ 2 files changed, 58 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 000000000..dd84ea782 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,38 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: '' +assignees: '' + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Desktop (please complete the following information):** + - OS: [e.g. iOS] + - Browser [e.g. chrome, safari] + - Version [e.g. 22] + +**Smartphone (please complete the following information):** + - Device: [e.g. iPhone6] + - OS: [e.g. iOS8.1] + - Browser [e.g. stock browser, safari] + - Version [e.g. 22] + +**Additional context** +Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 000000000..bbcbbe7d6 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,20 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: '' +assignees: '' + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. From 2e7e9389c038a14f4b8bddc19246906b7bc5bf13 Mon Sep 17 00:00:00 2001 From: Al-Raheem Date: Thu, 9 May 2019 14:35:41 +0800 Subject: [PATCH 4/5] fix: fixes #11 fixes issue #11 causing radio button conflicts in radiogroup component #11 --- src/RadioGroup/RadioGroup.tsx | 39 ++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/src/RadioGroup/RadioGroup.tsx b/src/RadioGroup/RadioGroup.tsx index 0f98cc0eb..30e9dd477 100644 --- a/src/RadioGroup/RadioGroup.tsx +++ b/src/RadioGroup/RadioGroup.tsx @@ -31,25 +31,26 @@ export const RadioGroup: React.FunctionComponent = (props: Radi
{props.label && } - {props.list && props.list.map((item, index) => -
- - - { props.onChange(item.value); }} - /> - - - {item.description && {item.description}} -
- )} + {props.list && props.list.map((item, index) => { + const identifier: string = item.label.replace(" ", "_") + Math.floor(Math.random() * 100) + (new Date()).getTime(); + return ( +
+ + { props.onChange(item.value); }} + /> + + {item.description && {item.description}} +
+ ); + })} {props.error &&
{props.error}
}
From 51a3ba096c3d6e2b4687061bd8aefd875f1f3852 Mon Sep 17 00:00:00 2001 From: Al-Raheem Date: Thu, 9 May 2019 14:47:19 +0800 Subject: [PATCH 5/5] fix: fixes #12 fixed radio buttons vertical alignment seen when using it inline #12 --- src/RadioGroup/radio-group-style.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/RadioGroup/radio-group-style.scss b/src/RadioGroup/radio-group-style.scss index be57996c5..3d1fbcff6 100644 --- a/src/RadioGroup/radio-group-style.scss +++ b/src/RadioGroup/radio-group-style.scss @@ -15,6 +15,7 @@ $red: #F03529; user-select: none; transition: all $transition-time; .radio-item { + vertical-align: top; position: relative; margin-bottom: 5px; input[type=radio] {