Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button label property does not work #544

Open
vladislavgoltjajev opened this issue Feb 9, 2021 · 1 comment
Open

Button label property does not work #544

vladislavgoltjajev opened this issue Feb 9, 2021 · 1 comment

Comments

@vladislavgoltjajev
Copy link

Button label does not work.
The HTML:

<sebng-button label="Button"></sebng-button>

produces a button with no label instead of a button with the label "Button".
Only works like this:

<sebng-button>Button</sebng-button>

Library version is 1.0.0-beta.14.

@omarVodiaK
Copy link
Contributor

omarVodiaK commented Feb 19, 2021

Hello,
Thank you for reaching out, the way to move forward is like this:

<sebng-button>Button</sebng-button>

the reason behind this change is to allow the button to accept any type of content rather than a string only, for example

<sebng-button><icon /></sebng-button>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants