From 23b02114a7d70c95eb7660ff2bd8eeab928ab725 Mon Sep 17 00:00:00 2001
From: mortendevold <2213243+mortendevold@users.noreply.github.com>
Date: Mon, 18 Dec 2023 09:15:45 +0100
Subject: [PATCH] Method signature and interface fixes (#2)

* Fix object selection and listing interfaces

* Remove unused import

* Add id to InteractiveObjectProps

* Remove id property

* Make findObject generic
---
 src/index.test.ts | 25 ++++++++++++++++++++++++-
 src/index.ts      |  8 ++++----
 2 files changed, 28 insertions(+), 5 deletions(-)

diff --git a/src/index.test.ts b/src/index.test.ts
index bbed43f..0db5767 100644
--- a/src/index.test.ts
+++ b/src/index.test.ts
@@ -262,7 +262,7 @@ new seatsio.EventManager({
 })
 
 // Global seatsio object works as expected
-new seatsio.SeatingChart({
+const seatingChart = new seatsio.SeatingChart({
     workspaceKey: 'myWorkspaceKey',
     event: 'myEvent'
 })
@@ -275,4 +275,27 @@ new seatsio.EventManager({
 
 new seatsio.SeatingChartDesigner({
     secretKey: 'mySecretKey'
+})
+
+// Seating chart tests
+seatingChart.selectObjects(['A1', { id: 'someId', ticketType: 'aTicketType', amount: 2}])
+seatingChart.deselectObjects(['A1', { id: 'someId', ticketType: 'aTicketType', amount: 2}])
+
+seatingChart.listSelectedObjects().then(objects => {
+    objects.forEach(obj => {
+        obj.accessible
+        obj.category
+        obj.companionSeat
+        obj.deselect
+        obj.displayObjectType
+        obj.label
+        obj.labels
+        obj.objectType
+        obj.pricing
+        obj.restrictedView
+        obj.select
+        obj.selectable
+        obj.selected
+        obj.selectedTicketType
+    })
 })
\ No newline at end of file
diff --git a/src/index.ts b/src/index.ts
index a03eb44..7210259 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -1215,19 +1215,19 @@ export interface SeatingChart {
     changeConfig: (config: ConfigChange) => Promise<void>
     clearSelection: () => Promise<void>
     deselectCategories: (categoryIds: string[]) => Promise<void>
-    deselectObjects: (objects: string[] | Selection[]) => Promise<void>
+    deselectObjects: (objects: (string | Selection)[]) => Promise<void>
     destroy: () => void
-    findObject: (label: string) => Promise<SelectableObjectProps>
+    findObject: <T extends SelectableObjectProps>(label: string) => Promise<T>
     getReportBySelectability: () => Promise<Object>
     holdToken: string
     listCategories: () => Promise<Category[]>
-    listSelectedObjects: () => Promise<(any)[]>
+    listSelectedObjects: <T extends SelectableObjectProps>() => Promise<T[]>
     render: () => SeatingChart
     rerender: () => void
     resetView: () => Promise<void>
     selectCategories: (categoryIds: string[]) => Promise<void>
     selectedObjects: string[]
-    selectObjects: (objects: string [] | Selection[]) => Promise<void>
+    selectObjects: (objects: (string | Selection)[]) => Promise<void>
     pulse: (objects: string []) => Promise<void>
     unpulse: (objects: string []) => Promise<void>
     startNewSession: () => Promise<void>