Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types on SelectableObject don't include all types actually in object #243

Open
J-Gonzalez opened this issue Dec 11, 2024 · 0 comments
Open

Comments

@J-Gonzalez
Copy link

We're upgrading to the latest SeatsIO React lib.

We noticed that

<SeatsioSeatingChart
     onObjectSelected={selectSeats}
     onObjectDeselected={removeSeat}
     ...
/>

now enforces the type on these functions to be SelectableObject (which is great, because prior we had to define our own types here)

However, the SelectableObject typing seems to be missing some key items. Keys like "id", "numSelected", and others, but the keys are definitely in the object that gets called in the function.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant