Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding and completing two or more new tasks in one session doesn't work. #240

Closed
bradleycoleman opened this issue Apr 9, 2020 · 3 comments · Fixed by #253
Closed

Adding and completing two or more new tasks in one session doesn't work. #240

bradleycoleman opened this issue Apr 9, 2020 · 3 comments · Fixed by #253
Assignees
@preetpatel
Labels
bug Something isn't working

Comments

@bradleycoleman
Copy link
Contributor

bradleycoleman commented Apr 9, 2020 •
edited
Loading

Bug Summary:

If more than one task is added in a single session, then opening the popup for any of them and attempting to toggle their completeness will only toggle the completeness of the task scheduled first, even if it is marked as complete in the correct order.

Steps To Reproduce

  1. Create two new tasks
  2. Attempt to toggle the completeness of the second scheduled task

Expected behaviour

The second task is marked as complete.

Observed Behaviour

The first task is marked as complete. Any further toggling of either tasks' completeness will only affect the first task until you refresh.

Screenshots

Two tasks are added:
image

I attempt to mark the second as complete, but it actually marks the first. If the first task is marked as complete first, then it will be marked as incomplete when you attempt to complete the second:

image

Environment

  • Version: Commit bd15bc5d.
  • Operating System: Windows 10
  • Browser (if any): Chrome

Additional Information:
@bradleycoleman bradleycoleman added the bug Something isn't working label Apr 9, 2020
@HarrisonLeach1
Copy link
Contributor

Nice one @bradleycoleman

@preetpatel preetpatel self-assigned this Apr 14, 2020
@HarrisonLeach1 HarrisonLeach1 added the BLOCKED The issue cannot be worked on because it is depends on another issue label Apr 17, 2020
@HarrisonLeach1
Copy link
Contributor

This is potentially caused by #250 so we will have to wait till that is fixed before work can begin on this.

@HarrisonLeach1 HarrisonLeach1 mentioned this issue Apr 17, 2020
Closed
@preetpatel preetpatel linked a pull request Apr 17, 2020 that will close this issue
bug/250-Ensure taskID is set before passing it on to backend Closes #250 and #240 #253
Merged
11 tasks
@preetpatel preetpatel removed the BLOCKED The issue cannot be worked on because it is depends on another issue label Apr 17, 2020
@preetpatel
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@preetpatel preetpatel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug/250-Ensure taskID is set before passing it on to backend Closes #250 and #240 preetpatel/Doto
3 participants
@preetpatel @bradleycoleman @HarrisonLeach1