-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove compiled code from git repository #101
Comments
I see you points, cause indeed it makes code review a bit polluted, but let me think a bit about that, cause I have some concerns |
@wilgert Can you clarify what exactly you are suggesting? Cause the guy in the article first created branches for each release (which is okeish), but then switched to unpkg (which is a bit not okay) I do have some concerns:
|
I suggest that the compiled version is not committed to git but only generated during the build in Github Actions/ Travis/ CircleCI (I don't care which one).
|
@wilgert Well, don't get me wrong - that's sounds reasonable. But that means we have to setup publish process somewhere on CI/GH Actions or whatever. That's the thing to do. Cause atm I just make releases via cli |
I think compiled code should not be included in the git repository.
Instead, it should be generated during the build and published in the release.
See also: https://kentcdodds.com/blog/why-i-dont-commit-generated-files-to-master
The text was updated successfully, but these errors were encountered: