Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compiled code from git repository #101

Open
wilgert opened this issue Apr 17, 2020 · 4 comments
Open

Remove compiled code from git repository #101

wilgert opened this issue Apr 17, 2020 · 4 comments

Comments

@wilgert
Copy link
Collaborator

wilgert commented Apr 17, 2020

I think compiled code should not be included in the git repository.
Instead, it should be generated during the build and published in the release.

See also: https://kentcdodds.com/blog/why-i-dont-commit-generated-files-to-master

@se-panfilov
Copy link
Owner

I see you points, cause indeed it makes code review a bit polluted, but let me think a bit about that, cause I have some concerns

@se-panfilov
Copy link
Owner

@wilgert Can you clarify what exactly you are suggesting?

Cause the guy in the article first created branches for each release (which is okeish), but then switched to unpkg (which is a bit not okay)

I do have some concerns:

@wilgert
Copy link
Collaborator Author

wilgert commented Apr 22, 2020

I suggest that the compiled version is not committed to git but only generated during the build in Github Actions/ Travis/ CircleCI (I don't care which one).

  • I think making this change should not hinder you in using GitHub packages
  • If you publish the same package as a release on GitHub and a package on npm I think you have your second concern covered.
  • I think you only need to add some paths to .gitignore and make sure a build is ran in a CI environment whenever you want to do a release.

@se-panfilov
Copy link
Owner

@wilgert Well, don't get me wrong - that's sounds reasonable. But that means we have to setup publish process somewhere on CI/GH Actions or whatever.

That's the thing to do. Cause atm I just make releases via cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants