Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

functions "generate_cond_from_condition_column_info" and "sample_original_condvec" #273

Open
Hamideh-Mehri opened this issue Feb 25, 2023 · 1 comment
Open

functions "generate_cond_from_condition_column_info" and "sample_original_condvec" #273

Hamideh-Mehri opened this issue Feb 25, 2023 · 1 comment
Labels
bug Something isn't working pending review This issue needs to be further reviewed, so work cannot be started

Comments

@Hamideh-Mehri
Copy link

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • CTGAN version:
  • Python version:
  • Operating System:

Error Description

Hello,

I think that two functions "generate_cond_from_condition_column_info" and "sample_original_condvec" does not produce conditional vector correctly. the issue is " _discrete_column_matrix_st" which always contains zeroes, and is not assigned properly.

I would really appreciate it if let me know whether I am correct or not.

Steps to reproduce

Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.
@Hamideh-Mehri Hamideh-Mehri added bug Something isn't working pending review This issue needs to be further reviewed, so work cannot be started labels Feb 25, 2023
@AndresAlgaba
Copy link

Hi @Hamideh-Mehri, maybe you can look at my PR: #236. I believe this fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pending review This issue needs to be further reviewed, so work cannot be started
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndresAlgaba @Hamideh-Mehri