Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add database primary replica configuration #14

Open
wants to merge 2 commits into
base: chore/chef-12-aws
Choose a base branch
from
Open

Add database primary replica configuration #14

wants to merge 2 commits into from

Conversation

ikirifqi
Copy link

@ikirifqi ikirifqi commented Oct 11, 2023 •
edited
Loading

@ikirifqi ikirifqi self-assigned this Oct 11, 2023
@ikirifqi ikirifqi force-pushed the database-replica-rails-6 branch 2 times, most recently from 0a47e63 to e92fcaa Compare October 11, 2023 08:19
@ikirifqi ikirifqi marked this pull request as ready for review October 12, 2023 02:42
shkrt
shkrt reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@shkrt shkrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about sidekiq? Sidekiq instances have different way of setting replica

@praveendhawan praveendhawan force-pushed the database-replica-rails-6 branch from 4d4e22d to e4932e0 Compare January 8, 2024 10:24
@praveendhawan praveendhawan force-pushed the database-replica-rails-6 branch from 3c4dd81 to d862a43 Compare February 27, 2024 10:50
@ikirifqi ikirifqi force-pushed the database-replica-rails-6 branch from 0b28e8f to 35e8ccf Compare April 12, 2024 10:06
@ikirifqi ikirifqi requested a review from shkrt April 12, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveendhawan praveendhawan praveendhawan approved these changes

@shkrt shkrt shkrt approved these changes

@robinhandoko robinhandoko Awaiting requested review from robinhandoko

@mohamedelkadi mohamedelkadi Awaiting requested review from mohamedelkadi

Assignees

@ikirifqi ikirifqi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikirifqi @shkrt @praveendhawan